https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It indeed always displayed the current user: <strong>Received by:</strong> [% logged_in_user.userid | html %] This is on the receive, not on the invoice page, although both are linked of course. We don't store who started/created an invoice. Also: The orders in a shipment/invoice could have been processed by different people, it makes no sense to display a single user at the top, when it can vary for different entries on the page. So I think best is to remove the misleading information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ID of currently logged in |When receiving an order, |user is displayed on the |information about user and |order receive page as |date on top are incorrect |"Received by" (parcel.pl) | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually, the same is true for the "On" date. It always displays today's date... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103208&action=edit Bug 17458: Fix information shown on top of order receive page Before this patch the order receive page (parcel.pl) would show ... Received by: <current user> On: <current date> This is not really helpful. Whenever you viewed an invoice, it would tell you it was _you_ who received that _today_. As we don't store a creator of an invoice and the order lines in an invoice could have been received by different people (which we also don't know about), the "Received by" is removed by this patch. Instead of today's date, we can show the shipment date entered for the invoice. Again: different order lines could have been received on different dates for this shipment. To test: - Create a basket with some orders in acq - Close the basket - Receive shipment and create an invoice - Make sure shipment date is not set to today - Verify the information shown on top of parcel.pl is you and today - Change staff users - Go to your invoice, it's now this user and today - Apply patch - Received by: should be gone and the On: replaced by Shipment date: with the date you selected If you have older invoices in your system, it would work even better with these as you'd see that always today's date is displaying without the patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Katrin, there are occurrences of "datereceived" in the template, however you removed it from the .pl file. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103263|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108279&action=edit Bug 17458: Remove use of datereceived from order receive page Before this patch the order receive page (parcel.pl) would show ... Received by: <current user> On: <current date> This is not really helpful. Whenever you viewed an invoice, it would tell you it was _you_ who received that _today_. As we don't store a creator of an invoice and the order lines in an invoice could have been received by different people (which we also don't know about), the "Received by" is removed by this patch. Instead of today's date, we can show the shipment date entered for the invoice. Again: different order lines could have been received on different dates for this shipment. So only the shipment date makes sense as it's on invoice level. This also makes changes to the page title, breadcrumby and page heading: When the invoice is closed, they will read: Receipt summary for [vendor] ... When the invoice is not closed, they wil read: Receive orders from [vendor] ... To test: - Create a basket with some orders in acq - Close the basket - Receive shipment and create an invoice - Make sure shipment date is not set to today - Verify the information shown on top of parcel.pl is you and today - Change staff users - Go to your invoice, it's now this user and today - Apply patch - Received by: should be gone and the On: replaced by Shipment date: with the date you selected - Check the page title, breadcrumbs and headings read all the same 'Receive orders...' - Finish receiving and close the invoice - "Go to receipt page" - Verify they now read "Receipt summary.." If you have older invoices in your system, it would work even better with these as you'd see that always today's date is displaying without the patch. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Test plan was amended, these are the new bits: This also makes changes to the page title, breadcrumby and page heading: When the invoice is closed, they will read: Receipt summary for [vendor] ... When the invoice is not closed, they wil read: Receive orders from [vendor] ... ... - Check the page title, breadcrumbs and headings read all the same 'Receive orders...' - Finish receiving and close the invoice - "Go to receipt page" - Verify they now read "Receipt summary.." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108279|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 110302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110302&action=edit Bug 17458: Remove use of datereceived from order receive page Before this patch the order receive page (parcel.pl) would show ... Received by: <current user> On: <current date> This is not really helpful. Whenever you viewed an invoice, it would tell you it was _you_ who received that _today_. As we don't store a creator of an invoice and the order lines in an invoice could have been received by different people (which we also don't know about), the "Received by" is removed by this patch. Instead of today's date, we can show the shipment date entered for the invoice. Again: different order lines could have been received on different dates for this shipment. So only the shipment date makes sense as it's on invoice level. This also makes changes to the page title, breadcrumby and page heading: When the invoice is closed, they will read: Receipt summary for [vendor] ... When the invoice is not closed, they wil read: Receive orders from [vendor] ... To test: - Create a basket with some orders in acq - Close the basket - Receive shipment and create an invoice - Make sure shipment date is not set to today - Verify the information shown on top of parcel.pl is you and today - Change staff users - Go to your invoice, it's now this user and today - Apply patch - Received by: should be gone and the On: replaced by Shipment date: with the date you selected - Check the page title, breadcrumbs and headings read all the same 'Receive orders...' - Finish receiving and close the invoice - "Go to receipt page" - Verify they now read "Receipt summary.." If you have older invoices in your system, it would work even better with these as you'd see that always today's date is displaying without the patch. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Well sleuthed, it's clearer now. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17458 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.