[Bug 26490] New: Column configuration for account-fines hides the wrong columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 Bug ID: 26490 Summary: Column configuration for account-fines hides the wrong columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Hello! I was trying to find out how to hide the "Home library" column from the transactions table in the patron's account (Patron account > Accounting tab > Transactions tab). The right column id in Table settings is account-fines (Administration > Table settings > Patrons > account-fines). There are two problems here: 1) The home library column doesn't appear in the table settings for account-fines 2) Checking the notes column in the account-fines table settings hides the home library column This means that because there are columns missing, the other ones are off. To replicate on master: 1) Go to a patron's account 2) Click on the Accounting tab and then the Transactions tab 3) In another browser tab, go to Administration > Table settings > Patrons 4) In the account-fines table, check the box to hide the Notes column 5) Go back to the patron's account and refresh the page. Notice the Notes column is still there but the Home library column is not there anymore I think Home library is the only missing column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110440&action=edit Bug 24690: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110440|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 110546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110546&action=edit Bug 24690: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option https://bugs.koha-community.org/show_bug.cgi?id=26490 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110742&action=edit Bug 26490: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #110546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ooops; Works as expected, thanks for the fix Katrin. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- doesnt apply cleanly to 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org