https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Failed QA --- Comment #102 from Julian Maurice <julian.maurice@biblibre.com> --- QA: I haven't tested it yet, but: 1) koha-qa reports a weird error about Koha::Authority::MergeRequest(s) : $ perl -cw Koha/Authority/MergeRequest.pm Inconsistent hierarchy during C3 merge of class 'Koha::Authority::MergeRequest': current merge results [ Koha::Authority::MergeRequest, ] merging failed on 'Koha::Object' at /usr/share/perl/5.20/parent.pm line 26. BEGIN failed--compilation aborted at /home/koha/env/master/src/Koha/Authority/MergeRequest.pm line 22. Compilation failed in require at /home/koha/env/master/src/Koha/Authority/MergeRequests.pm line 25. BEGIN failed--compilation aborted at /home/koha/env/master/src/Koha/Authority/MergeRequests.pm line 25. Compilation failed in require at Koha/Authority/MergeRequest.pm line 25. BEGIN failed--compilation aborted at Koha/Authority/MergeRequest.pm line 25. It seems to be because of circular dependency between the two modules. If I remove 'use Koha::Authority::MergeRequest;' from Koha::Authority::MergeRequests, there is no error. 2) koha-qa also complains about POD: *** WARNING: empty section in previous paragraph in file Koha/Authority/MergeRequests.pm 3) t/db_dependent/Koha/Authorities.t fails with a UNIMARC setup $ prove t/db_dependent/Koha/Authorities.t [2/8764] t/db_dependent/Koha/Authorities.t .. 1/6 substr outside of string at /usr/share/perl5/MARC/File/XML.pm line 561. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 563. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 563. Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 565. Use of uninitialized value $enc in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 568. # Looks like you planned 4 tests but ran 1. # Failed test 'New merge request, method oldmarc' # at t/db_dependent/Koha/Authorities.t line 97. Unsupported UNIMARC character encoding [] for XML output for UNIMARCAUTH; 100$a -> a at /usr/share/perl5/MARC/File/XML.pm line 568. # Looks like your test exited with 255 just after 4. t/db_dependent/Koha/Authorities.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/6 subtests Test Summary Report ------------------- t/db_dependent/Koha/Authorities.t (Wstat: 65280 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 255 Parse errors: Bad plan. You planned 6 tests but ran 4. Files=1, Tests=4, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.84 cusr 0.03 csys = 0.88 CPU) Result: FAIL 4) Koha::Authorities::get_usage_count and Koha::Authorities::linked_biblionumbers look very similar. Is there a real performance gain to use get_usage_count instead of linked_biblionumbers ? C4::Authorities::merge call them both and it looks like we could save one search request by calling only linked_biblionumbers -- You are receiving this mail because: You are watching all bug changes.