https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60104|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 60115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60115&action=edit Bug 18093: Add Koha::Objects->get_column Test plan: prove t/db_dependent/Koha/Objects.t Should return green Followed test plan, result as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This method now returns a DBIx::Class::ResultSetColumn object. I am wondering if we should do that. It seems not to fit in the current design of Koha::Object[s]. Maybe you need to elaborate first on how we are going to use this method first ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #4)

I wanted to add a follow-up for something but finally did not need it. It is not important for now, but we may need it later.

How would you use it? Koha Objects more-or-less encapsulate DBIx, but here you do not. Would returning an array of values be enough? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #5)

(In reply to Jonathan Druart from comment #4)

...

I wanted to add a follow-up for something but finally did not need it. It is not important for now, but we may need it later.

How would you use it?

I would have used it how I did in the test.

Koha Objects more-or-less encapsulate DBIx, but here you do not. Would returning an array of values be enough?

Do you think it's better with this second patch? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60115|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61155&action=edit Bug 18093: Add Koha::Objects->get_column Test plan: prove t/db_dependent/Koha/Objects.t Should return green Followed test plan, result as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18295 Depends on|18295 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 [Bug 18295] C4::Items - Remove get_itemnumbers_of -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.