[Bug 40800] New: TransferArrived needlessly triggers alerts in SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Bug ID: 40800 Summary: TransferArrived needlessly triggers alerts in SIP Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org A SIP check-in incorrectly triggers alerts when receiving items in transit at the destination library due to the NotIssued status combined with the TransferArrived message. When an item in transit is checked in at its destination library via SIP clients (sorters, self-service kiosks), the system generates an alert because it finds both: * NotIssued status (item not checked out to a user), therefore a checkin failure * Transfer receipt message Whilst this combination appropriately provides informational messages in the staff client, it's inappropriate for SIP contexts where automated systems don't require transfer receipt notifications and the alert disrupts workflow. The item status transition works correctly (transit → available), but the SIP response incorrectly signals an alert condition, preventing automated systems like sorters from processing transferred items seamlessly. Expected Behaviour SIP check-in of transit items at destination libraries should complete without alerts, allowing automated systems to process transferred items without manual intervention. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186385&action=edit Bug 40800: SIP checkin incorrectly triggering alerts on successful transfer completion When an item is checked in via SIP2 at the correct target branch after a transfer, the system was incorrectly triggering an alert flag. This occurred because the TransferArrived message was not being filtered out for accounts with checked_in_ok="1", causing the alert logic to treat successful transfer completion as a failure condition. The TransferArrived message indicates successful transfer completion and is purely informational - it should not trigger SIP alerts. This fix ensures that TransferArrived messages are filtered out before alert evaluation, preventing false positive alerts on successful operations. Test Plan: 1. Set up a SIP2 account with checked_in_ok="1" in SIPconfig.xml 2. Via staff client, check out an item to a patron 3. Return the item to a different branch to trigger a transfer 4. Use misc/sip_cli_emulator.pl to check in the item at the target branch 5. Verify SIP response shows alert flag 'N' (no alert) instead of 'Y' 6. Test wrong branch checkin still shows alert flag 'Y' with CV04 type Before: Transfer completion at correct branch incorrectly shows alert='Y' After: Transfer completion at correct branch correctly shows alert='N' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186386&action=edit Bug 40800: Add unit test for SIP TransferArrived alert fix This test verifies that the TransferArrived message is properly filtered out during SIP checkin operations to prevent false positive alerts when an item is successfully checked in at the correct transfer destination. The test creates a transfer scenario and confirms that: 1. TransferArrived messages are filtered out of the response 2. No alert_type is set for successful transfer completion 3. Alert flag remains false for accounts with checked_in_ok=1 4. Transaction is marked as successful This validates the fix for the bug where SIP was incorrectly triggering alerts on successful transfer completion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried to see if I could test this, but: Test plan says that you should create a SIP account with checked_in_ok="1": Test Plan: 1. Set up a SIP2 account with checked_in_ok="1" in SIPconfig.xml 2. Via staff client, check out an item to a patron And in the second patch: 3. Alert flag remains false for accounts with checked_in_ok=1 But the code doesn't check for this condition for "TransferArrived": # TransferArrived is informational and should not trigger alerts delete $messages->{TransferArrived}; if ($checked_in_ok) { delete $messages->{ItemLocationUpdated}; delete $messages->{NotIssued}; delete $messages->{LocalUse}; $return = 1 unless keys %$messages; } Can you please clarify? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Comma delimited| |OpenFifth list of Sponsors| |<https://openfifth.co.uk> Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186385|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186386|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192847&action=edit Bug 40800: SIP checkin incorrectly triggering alerts on successful transfer completion When an item is checked in via SIP2 at the correct target branch after a transfer, the system was incorrectly triggering an alert flag. This occurred because the TransferArrived message was not being filtered out for accounts with checked_in_ok="1", causing the alert logic to treat successful transfer completion as a failure condition. The TransferArrived message indicates successful transfer completion and is purely informational - it should not trigger SIP alerts. This fix ensures that TransferArrived messages are filtered out before alert evaluation, preventing false positive alerts on successful operations. Test Plan: 1. Set up a SIP2 account with checked_in_ok="1" in SIPconfig.xml 2. Via staff client, check out an item to a patron 3. Return the item to a different branch to trigger a transfer 4. Use misc/sip_cli_emulator.pl to check in the item at the target branch 5. Verify SIP response shows alert flag 'N' (no alert) instead of 'Y' 6. Test wrong branch checkin still shows alert flag 'Y' with CV04 type Before: Transfer completion at correct branch incorrectly shows alert='Y' After: Transfer completion at correct branch correctly shows alert='N' Sponsored-by: OpenFifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192848&action=edit Bug 40800: Add unit test for SIP TransferArrived alert fix This test verifies that the TransferArrived message is properly filtered out during SIP checkin operations to prevent false positive alerts when an item is successfully checked in at the correct transfer destination. The test creates a transfer scenario and confirms that: 1. TransferArrived messages are filtered out of the response 2. No alert_type is set for successful transfer completion 3. Alert flag remains false for accounts with checked_in_ok=1 4. Transaction is marked as successful This validates the fix for the bug where SIP was incorrectly triggering alerts on successful transfer completion. Sponsored-by: OpenFifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Well spotted Katrin.. seems I was in a bit of a brain fade when I first wrote this. I've amended the patch now to match the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192847|0 |1 is obsolete| | Attachment #192848|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200921&action=edit Bug 40800: SIP checkin incorrectly triggering alerts on successful transfer completion When an item is checked in via SIP2 at the correct target branch after a transfer, the system was incorrectly triggering an alert flag. This occurred because the TransferArrived message was not being filtered out for accounts with checked_in_ok="1", causing the alert logic to treat successful transfer completion as a failure condition. The TransferArrived message indicates successful transfer completion and is purely informational - it should not trigger SIP alerts. This fix ensures that TransferArrived messages are filtered out before alert evaluation, preventing false positive alerts on successful operations. Test Plan: 1. Set up a SIP2 account with checked_in_ok="1" in SIPconfig.xml 2. Via staff client, check out an item to a patron 3. Return the item to a different branch to trigger a transfer 4. Use misc/sip_cli_emulator.pl to check in the item at the target branch 5. Verify SIP response shows alert flag 'N' (no alert) instead of 'Y' 6. Test wrong branch checkin still shows alert flag 'Y' with CV04 type Before: Transfer completion at correct branch incorrectly shows alert='Y' After: Transfer completion at correct branch correctly shows alert='N' Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200922&action=edit Bug 40800: Add unit test for SIP TransferArrived alert fix This test verifies that the TransferArrived message is properly filtered out during SIP checkin operations to prevent false positive alerts when an item is successfully checked in at the correct transfer destination. The test creates a transfer scenario and confirms that: 1. TransferArrived messages are filtered out of the response 2. No alert_type is set for successful transfer completion 3. Alert flag remains false for accounts with checked_in_ok=1 4. Transaction is marked as successful This validates the fix for the bug where SIP was incorrectly triggering alerts on successful transfer completion. Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200921|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200922|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #9 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201074&action=edit Bug 40800: SIP checkin incorrectly triggering alerts on successful transfer completion When an item is checked in via SIP2 at the correct target branch after a transfer, the system was incorrectly triggering an alert flag. This occurred because the TransferArrived message was not being filtered out for accounts with checked_in_ok="1", causing the alert logic to treat successful transfer completion as a failure condition. The TransferArrived message indicates successful transfer completion and is purely informational - it should not trigger SIP alerts. This fix ensures that TransferArrived messages are filtered out before alert evaluation, preventing false positive alerts on successful operations. Test Plan: 1. Set up a SIP2 account with checked_in_ok="1" in SIPconfig.xml 2. Via staff client, check out an item to a patron 3. Return the item to a different branch to trigger a transfer 4. Use misc/sip_cli_emulator.pl to check in the item at the target branch 5. Verify SIP response shows alert flag 'N' (no alert) instead of 'Y' 6. Test wrong branch checkin still shows alert flag 'Y' with CV04 type Before: Transfer completion at correct branch incorrectly shows alert='Y' After: Transfer completion at correct branch correctly shows alert='N' Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #10 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201075&action=edit Bug 40800: Add unit test for SIP TransferArrived alert fix This test verifies that the TransferArrived message is properly filtered out during SIP checkin operations to prevent false positive alerts when an item is successfully checked in at the correct transfer destination. The test creates a transfer scenario and confirms that: 1. TransferArrived messages are filtered out of the response 2. No alert_type is set for successful transfer completion 3. Alert flag remains false for accounts with checked_in_ok=1 4. Transaction is marked as successful This validates the fix for the bug where SIP was incorrectly triggering alerts on successful transfer completion. Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #11 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40800 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.05 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org