[Bug 23063] New: Add item does not respect CurrencyFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Bug ID: 23063 Summary: Add item does not respect CurrencyFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- Adding or editing an item, fields mapped to items.price and items.replacementprice do not obey CurrencyFormat. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are right, but it's the same for all price/monetary amounts. Koha currently only works with decimal . Something we need to find a global fix for - changing to enh. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|Add item does not respect |Item table in cataloguing |CurrencyFormat |doesn't respect | |CurrencyFormat -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140806&action=edit Bug 23063: Use Price formatting on amounts in item table in cataloguing Koha can use CurrencyFormat for displaying price amounts and should do so consistently everywhere. Without this patch price and replacement cost will always display as xx.xx independent of CurrencyFormat setting in the table above the edit items form. This patch fixes the table display. To test: * Apply patch * Search or create a record with multiple items * Fill in some price and replacement costs * Try different settings of the CurrencyFormat system preference * The display in the item table above the edit/add form should display according to the system preference * Verify sorting works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140806|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 140812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140812&action=edit Bug 23063: Use Price formatting on amounts in item table in cataloguing Koha can use CurrencyFormat for displaying price amounts and should do so consistently everywhere. Without this patch price and replacement cost will always display as xx.xx independent of CurrencyFormat setting in the table above the edit items form. This patch fixes the table display. To test: * Apply patch * Search or create a record with multiple items * Fill in some price and replacement costs * Try different settings of the CurrencyFormat system preference * The display in the item table above the edit/add form should display according to the system preference * Verify sorting works Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140812|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141259&action=edit Bug 23063: Use Price formatting on amounts in item table in cataloguing Koha can use CurrencyFormat for displaying price amounts and should do so consistently everywhere. Without this patch price and replacement cost will always display as xx.xx independent of CurrencyFormat setting in the table above the edit items form. This patch fixes the table display. To test: * Apply patch * Search or create a record with multiple items * Fill in some price and replacement costs * Try different settings of the CurrencyFormat system preference * The display in the item table above the edit/add form should display according to the system preference * Verify sorting works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This makes sure that the release notes| |price and replacement price | |of an item is displayed | |according to the | |CurrencyFormat setting in | |the items table above the | |add/edit item form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23063 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org