[Bug 30304] New: Reindent lists template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Bug ID: 30304 Summary: Reindent lists template in the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30031 I propose to reformat the lists template in the staff interface (shelves.tt) so that it has consistent spacing and indentation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 [Bug 30031] Add lists to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30309 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30309 [Bug 30309] Convert lists tabs in the staff interface to Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140348&action=edit Bug 30304: Reindent lists template in the staff interface This patch performs general template cleanup to the lists template: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and test all aspects of the lists pages, including: - Viewing the list of public and private lists. - List of lists DataTable controls: Paging, filtering, sorting. - Add, edit and delete lists. - View list contents. - Remove titles from a list. - Place hold from a list. - Add items to a list. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag. The only changes you see should be split lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140349&action=edit Bug 30304: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30031 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 [Bug 30031] Add lists to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140348|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140395&action=edit Bug 30304: Reindent lists template in the staff interface This patch performs general template cleanup to the lists template: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and test all aspects of the lists pages, including: - Viewing the list of public and private lists. - List of lists DataTable controls: Paging, filtering, sorting. - Add, edit and delete lists. - View list contents. - Remove titles from a list. - Place hold from a list. - Add items to a list. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag. The only changes you see should be split lines. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140349|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140396&action=edit Bug 30304: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141181&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I didn't realize that I had already signed off... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- These changes look good. The diff is is good. I also checked this through the W3 HTML validator. There is some warnings that are new to me: "Self-closing tag syntax in text/html documents is widely discouraged; it’s unnecessary and interacts badly with other HTML features" If we need to change the self ending tags I think we should do so in a separate bug report. Or maybe, since it is a warning, it is not necessary to address? Either way, I am passing QA on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140395|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141271&action=edit Bug 30304: Reindent lists template in the staff interface This patch performs general template cleanup to the lists template: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and test all aspects of the lists pages, including: - Viewing the list of public and private lists. - List of lists DataTable controls: Paging, filtering, sorting. - Add, edit and delete lists. - View list contents. - Remove titles from a list. - Place hold from a list. - Add items to a list. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag. The only changes you see should be split lines. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140396|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141272&action=edit Bug 30304: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30304 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org