[Bug 32211] New: Update sample (pre) due notices to use TT syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Bug ID: 32211 Summary: Update sample (pre) due notices to use TT syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 29100 With 29100 we can improve the notices to show how TT can be used to get all the information we need here and have nice formatting (replacing items.content especially). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100 [Bug 29100] Add checkouts data loop to predue/due notices script (advance_notices.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- DUE and PREDUE got handled in Bug 36106, but we still need to update the digest versions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175337&action=edit Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36106 Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |no-sandbox CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |blawlor@clamsnet.org --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- The email type Item due reminder notice has a small mistake. On line 744 the checkouts array variable name needs to be in lowercase like [% FOREACH checkout IN checkouts %] or else the items' title author and barcode do not render. The other 3 notices displayed correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175337|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 176390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176390&action=edit Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT update to correct CHECKOUT capitalization To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #3)
The email type Item due reminder notice has a small mistake.
On line 744 the checkouts array variable name needs to be in lowercase like [% FOREACH checkout IN checkouts %]
or else the items' title author and barcode do not render.
The other 3 notices displayed correctly
Whoops! Thanks for catching. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175337|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175337|0 |1 is obsolete| | Attachment #176390|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 176391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176391&action=edit Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 176392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176392&action=edit Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT update to correct CHECKOUT capitalization To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176391|0 |1 is obsolete| | Attachment #176392|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176652&action=edit Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|no-sandbox | QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update sample (pre) due |Update sample (PRE)DUE |notices to use TT syntax |notices to use Template | |Toolkit syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32211 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Text of notices is not documented in the manual. Nothing to change here. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org