[Bug 37955] New: Clicking table's 'configure' button no longer opens column settings page properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Bug ID: 37955 Summary: Clicking table's 'configure' button no longer opens column settings page properly Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, jonathan.druart@gmail.com, katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, oleonard@myacpl.org, paul.derscheid@lmscloud.de When clicking on the 'Configure' button on any table, the column settings page no longer navigates (and expands) the relevant table settings. Mattermost discussion thread: https://chat.koha-community.org/koha-community/pl/oarowazpat8kfe4cozbjftidya -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171661&action=edit Bug 37955: Fix table's 'configure' button to open correct column settings This patch updates markup and JS code on the table settings page so that clicking a table's "configure" button will open the right panel and scroll you to the correct table. The patch also overrides Bootstrap's default table caption positioning so that captions are above the table instead of below them. Unfortunately this property isn't in Bootstrap's _variables. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Find a table in the staff interface which has a "Configure" button, e.g. Administration -> Libraries. - Click the "Configure" button. - When you arrive at the table settings page the correct panel should be expanded (in this example, Administration), and the page should scroll to the correct table (in this example, libraries). - The table caption ("Table id: libraries") should appear before the table instead of after. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171661|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 171684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171684&action=edit Bug 37955: Fix table's 'configure' button to open correct column settings This patch updates markup and JS code on the table settings page so that clicking a table's "configure" button will open the right panel and scroll you to the correct table. The patch also overrides Bootstrap's default table caption positioning so that captions are above the table instead of below them. Unfortunately this property isn't in Bootstrap's _variables. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Find a table in the staff interface which has a "Configure" button, e.g. Administration -> Libraries. - Click the "Configure" button. - When you arrive at the table settings page the correct panel should be expanded (in this example, Administration), and the page should scroll to the correct table (in this example, libraries). - The table caption ("Table id: libraries") should appear before the table instead of after. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171684|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171710&action=edit Bug 37955: Fix table's 'configure' button to open correct column settings This patch updates markup and JS code on the table settings page so that clicking a table's "configure" button will open the right panel and scroll you to the correct table. The patch also overrides Bootstrap's default table caption positioning so that captions are above the table instead of below them. Unfortunately this property isn't in Bootstrap's _variables. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Find a table in the staff interface which has a "Configure" button, e.g. Administration -> Libraries. - Click the "Configure" button. - When you arrive at the table settings page the correct panel should be expanded (in this example, Administration), and the page should scroll to the correct table (in this example, libraries). - The table caption ("Table id: libraries") should appear before the table instead of after. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38069 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- table_id was used later, the form cannot be saved, see bug 38069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 [Bug 38069] Table settings not saving -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Missing 24.05.x deps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39519 [Bug 39519] Cannot save default sort order for tables [regression] -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org