[Bug 38069] New: Table settings not saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Bug ID: 38069 Summary: Table settings not saving Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: System Administration Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you save the form nothing is saved (and all silent) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 [Bug 37955] Clicking table's 'configure' button no longer opens column settings page properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172335&action=edit Bug 38069: (bug 37955 follow-up) Fix edition of table settings The form cannot longer be saved, and no appear appear (nothing in log, nothing on the UI) This is coming from bug 37955 where we modify the table_id to fix anchors, but we didn't care of the rest of the code using this TT variable. This patch suggests to replace # and _ with | Test plan: Confirm that the form can be edited, saved, and that it is taken correctly into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172335|0 |1 is obsolete| | --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172364&action=edit Bug 38069: (bug 37955 follow-up) Fix edition of table settings The form cannot longer be saved, and no appear appear (nothing in log, nothing on the UI) This is coming from bug 37955 where we modify the table_id to fix anchors, but we didn't care of the rest of the code using this TT variable. This patch suggests to replace # and _ with | Test plan: Confirm that the form can be edited, saved, and that it is taken correctly into account. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Trivial, PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38107 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38107 [Bug 38107] Allow custom sort order of patron_holds_table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174462&action=edit Bug 38069: Fix jump to the correct table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked follow-up "Fix jump to correct table" for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174681&action=edit Bug 38069: (follow-up) Fix jump to the correct table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #7)
Created attachment 174681 [details] [review] Bug 38069: (follow-up) Fix jump to the correct table
Fixes JS error "Uncaught Error: Syntax error, unrecognized expression: #detail|holdings_table" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked the last patch "(follow-up) Fix jump to correct table" for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Bug 38069 depends on bug 37955, which changed state. Bug 37955 Summary: Clicking table's 'configure' button no longer opens column settings page properly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37955 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Not needed in 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38069 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39519 [Bug 39519] Cannot save default sort order for tables [regression] -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org