[Bug 30879] New: Add option to sort by local-number in zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Bug ID: 30879 Summary: Add option to sort by local-number in zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com Zebra sorting options are hardcoded - but trying to add local-number failed 375 elsif ( $sort eq "local-number_asc" ) { 376 $sort_by .= "1=12 <i "; 377 } 378 elsif ( $sort eq "local-number_dsc" ) { 379 $sort_by .= "1=12 >i "; 380 } I think it is because we index both as word and number 5 <!--record.abs line 24: melm 001 Local-number,Local-number:n--> 6 <index_control_field tag="001"> 7 <target_index>Local-number:w</target_index> 8 </index_control_field> 9 <index_control_field tag="001"> 10 <target_index>Local-number:n</target_index> 11 </index_control_field> I am not sure how to specify sorting by number index, and not word -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |martin.renvoize@ptfs-europe | |.com Depends on| |30327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 [Bug 30327] Sort component parts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #0)
I am not sure how to specify sorting by number index, and not word
The short answer is that you don't. If you look at ./etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl, you'll see that "pubdate" has a word, number, year, and sort index. You would just need to add Local-number:s for the target index. <z:index name="pubdate:w"> <xslo:value-of select="substring(., 8, 4)"/> </z:index> <z:index name="pubdate:n"> <xslo:value-of select="substring(., 8, 4)"/> </z:index> <z:index name="pubdate:y"> <xslo:value-of select="substring(., 8, 4)"/> </z:index> <z:index name="pubdate:s"> <xslo:value-of select="substring(., 8, 4)"/> </z:index> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136255&action=edit Bug 30879: Add option to sort components by biblionumber WIP This works for ES, but zebra sorts the biblionumber as a string, s=109 was my attempt based on https://software.indexdata.com/yaz/doc/tools.html#ccl.syntax which I don't fully understand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option to sort by |Add option to sort |local-number in zebra |components by biblionumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #2)
Created attachment 136255 [details] [review] Bug 30879: Add option to sort components by biblionumber
WIP
This works for ES, but zebra sorts the biblionumber as a string, s=109 was my attempt based on https://software.indexdata.com/yaz/doc/tools.html#ccl.syntax which I don't fully understand
Sorry but I think you gotten it a bit backwards 😅. First, it looks like you've updated the UNIMARC files for biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl instead of the MARC21 files. Second, you don't need that change to ccl.properties. -- And now that I'm looking more closely... it looks like we do already index 999$c into the following indexes/registers for MARC 21: Local-Number:n Local-Number:w Local-Number:s So I think you might be going down the wrong path... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Ok I understand what you're saying now... It's not that the sort fails completely. Rather, it's doing a lexicographic sort... so it'll go 1, 10, 2 for ascending 1=12 sort. Yeah that's annoying... Btw, one way to do tests for this is to use "yaz-client". Search on something like "e" in koha-testing-docker, and then run "sort 1=4 >i" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I think this is just a flaw in Zebra. I tried sorting by "itemnumber" which is just defined in the "n" and "s" registers, and it just lexically sorts as well. I've tried reading through the YAZ code which seems to be responsible for sorting, but the sort code is from 1998 and very difficult to understand. It looks like sorting updates the query... but I don't see anything that handles the actual "sorting". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #5)
I've tried reading through the YAZ code which seems to be responsible for sorting, but the sort code is from 1998 and very difficult to understand. It looks like sorting updates the query... but I don't see anything that handles the actual "sorting".
Ah I was looking at the wrong Zebra folder which is why my grepping was failing :| According to https://software.indexdata.com/zebra/doc/features.html#features-sort-rank: "Sorting on the basis of alpha-numeric and numeric data is supported." "Sorting on the basis of combined sorts e.g. combinations of ascending/descending sorts of lexicographical/numeric/date field data is supported" "All ordering operations are based on a lexicographical ordering, except when the structure attribute numeric (109) is used. In this case, ordering is numerical. See Section 2.4.3, “Structure Attributes (type 4)”." And that's why you've used that s=109 there... Their documentation sure is ambiguous... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- So I think that suggestion with the 4=109 probably only works when providing the 7 attribute: Ascending order: find @or @attr 1=1016 e @attr 7=1 @attr 1=Local-Number @attr 4=109 0 Descending order: find @or @attr 1=1016 e @attr 7=2 @attr 1=Local-Number @attr 4=109 0 (Highest bib is 389 in this case) -- But in this case we're using the ZOOM "sort" method to run the sort query separately from the main query, so I don't think it'll work, as the sort spec can't support it currently. I tried adding 4=109 to "Local-number" in ccl.properties and just sending "Local-number" via the sort and hoping it might do something but nope... -- So ultimately I'm thinking a bug/shortcoming in Zebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- https://github.com/indexdata/idzebra/issues/37 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for taking a look at this, David! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Our IDs all seem to be INT(11) in the DB - would it be reasonable to zero pad our ids into a new column to fix the sorting? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #10)
Our IDs all seem to be INT(11) in the DB - would it be reasonable to zero pad our ids into a new column to fix the sorting?
Zero padding the ID is smart thinking I reckon. In theory, we wouldn't need a new DB column. We'd just need to add something like the following to our Zebra indexing XSLT for a new custom index (e.g. Local-number-sort): <xsl:value-of select='format-number(1, "00000000000")' /> I think to update "./etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl", we'd need to update the template "handle-index-subfields" in ./etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136255|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136425&action=edit Bug 30879: Add biblionumber as a sorting option in MARC21 This patch updates the Local-Number indexing by adding a zeropad option to Zebra indexing and adding this to the mapping files It also updates C4/Search.pm to allow biblionumber as an option To test: 1 - Apply patches 2 - copy etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl to /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 3 - Restart all, reindex zebra 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_dsc&count=20 5 - Confirm records sorted correctly 6 - Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_asc&count=20 7 - Confirm records sorted correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136426&action=edit Bug 30879: Allow biblionumber as sort option in Elasticsearch Repeat previous tests with Elasticsearch engine You will need to reindex and reset mappings to pickup the changes form the file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136427&action=edit Bug 30879: Handle index/sorting for UNIMARC Same as before, but test with UNIMARC setup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136428&action=edit Bug 30879: Add option to syspref and update display To test: 1 - Update ComponentSortField system preference and verify biblionumber is an option 2 - Repeat test plan from 30327 and confirm sorting with biblionumber works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Can't really test this at the moment since bug 30879 can't apply on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- However, I'm pretty keen to test this Zebra indexing change, so I'll do a subtest. My test plan: 1. Apply patches for 30879 (w/o 30327 and nixing merge conflict due to missing 30327) 2. cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 3. restart_all 4. koha-rebuild-zebra -b -f -v kohadev 5. yaz-client unix:/var/run/koha/kohadev/bibliosocket 5b. find e 5c. sort 1=12 >i 6. show (through whole 64 record result set to confirm desc sort) -- It works 100% as you'd expect, so that's awesome. Great job, Nick! I'm so pleased how we got here using teamwork! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- Since 30327 has been updated... My test plan: 1 - Apply patches 2 - cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 3a - restart_all 3b - koha-rebuild-zebra -b -f -v kohadev 3c - koha-upgrade-schema kohadev 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_dsc&count=20 5 - Confirm records sorted correctly 6 - Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_asc&count=20 7 - Confirm records sorted correctly I don't know how to test the Elasticsearch or UNIMARC changes. I've changed "SearchEngine" to "Elasticsearch" and run "koha-elasticsearch --rebuild kohadev" which spat out the following: Cannot determine authority type for record: 1 at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 564. In the logs I'm seeing this error: [2022/06/24 02:25:42] [WARN] [Request] ** [http://es:9200]-[400] [query_shard_exception] No mapping found for [local-number__sort] in order to sort on, with: {"index":"koha_kohadev_biblios","index_uuid":"CVVpzugoRfqw7zsFft1pnQ"} Will need more specific instructions to test this one. I'll leave it as "Needs Signoff" rather than "Failed QA" in the event that someone else can test it correctly. -- The test plan for bug 30327 wasn't very specific in its instruction "Add some components to a record by control number or title depending on above", so I tried a lot of things... many which didn't work. Would've been nice to have more explicit steps there. Additional test plan: 1 - Update ComponentSortField system preference and verify biblionumber is an option 2 - Repeat test plan from 30327 and confirm sorting with biblionumber works This looks OK with Zebra. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136425|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136525&action=edit Bug 30879: Add biblionumber as a sorting option in MARC21 This patch updates the Local-Number indexing by adding a zeropad option to Zebra indexing and adding this to the mapping files It also updates C4/Search.pm to allow biblionumber as an option To test: 1 - Apply patches 2 - copy etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl to /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 3 - Restart all, reindex zebra 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_dsc&count=20 5 - Confirm records sorted correctly 6 - Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_asc&count=20 7 - Confirm records sorted correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136426|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136526&action=edit Bug 30879: Allow biblionumber as sort option in Elasticsearch Repeat previous tests with Elasticsearch engine You will need to reindex and reset mappings to pickup the changes form the file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136427|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136527&action=edit Bug 30879: Handle index/sorting for UNIMARC Same as before, but test with UNIMARC setup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136428|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136528&action=edit Bug 30879: Add option to syspref and update display To test: 1 - Update ComponentSortField system preference and verify biblionumber is an option 2 - Repeat test plan from 30327 and confirm sorting with biblionumber works Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome teamwork here guys, thankyou very much. All tested and working as expected from my side.. signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We need a rebase here please! Applying: Bug 30327: Add options for sorting components Using index info to reconstruct a base tree... M Koha/Biblio.pm M catalogue/detail.pl M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt M opac/opac-detail.pl M t/db_dependent/Koha/Biblio.t Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql CONFLICT (add/add): Merge conflict in installer/data/mysql/atomicupdate/bug_30327_add_sortComponents_syspref.pl Auto-merging installer/data/mysql/atomicupdate/bug_30327_add_sortComponents_syspref.pl Auto-merging Koha/Biblio.pm CONFLICT (content): Merge conflict in Koha/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 30327: Add options for sorting components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136525|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136545&action=edit Bug 30879: Add biblionumber as a sorting option in MARC21 This patch updates the Local-Number indexing by adding a zeropad option to Zebra indexing and adding this to the mapping files It also updates C4/Search.pm to allow biblionumber as an option To test: 1 - Apply patches 2 - copy etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl to /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 3 - Restart all, reindex zebra 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_dsc&count=20 5 - Confirm records sorted correctly 6 - Browse to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=a&sort_by=biblionumber_asc&count=20 7 - Confirm records sorted correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136526|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136546&action=edit Bug 30879: Allow biblionumber as sort option in Elasticsearch Repeat previous tests with Elasticsearch engine You will need to reindex and reset mappings to pickup the changes form the file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136527|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136547&action=edit Bug 30879: Handle index/sorting for UNIMARC Same as before, but test with UNIMARC setup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136528|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136548&action=edit Bug 30879: Add option to syspref and update display To test: 1 - Update ComponentSortField system preference and verify biblionumber is an option 2 - Repeat test plan from 30327 and confirm sorting with biblionumber works Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Happy to add a motivational sign-off, but: I wonder how we can make sure this feature works correctly for updated installations. 1) We should add a note to the release notes about this requiring to reindex. 2) For Zebra the update will usually just work, but what about Elasticsearch? We recently noticed that bug 15851 doesn't work for people because of the missing cni index. I'd like to avoid that here. Could we add a database update for updating the mappings? 3) Unit tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No reply from Nick yet, I think we still need the release notes note, but dropping the other requirement from my side. I believe this is worth having. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #30)
No reply from Nick yet, I think we still need the release notes note, but dropping the other requirement from my side. I believe this is worth having.
I think I drafted and never posted We need to solve the problem of differing settings in a larger way - if we are letting people define their own mappings we really can't update them without feedback - bug 30836 is the place to figure that out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13976 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | --- Comment #33 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #34 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on Bug30327 which i'm still waiting a valid patch for 21.11.x. Will only backport if I get an update on the dependancy. (don't know the status... on hold?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #35 from David Cook <dcook@prosentient.com.au> --- So I've got an update from Indexdata... It turns out that we could've just patched our Perl code to the following: 375 elsif ( $sort eq "local-number_asc" ) { 376 $sort_by .= "1=12,4=109 <i "; 377 } 378 elsif ( $sort eq "local-number_dsc" ) { 379 $sort_by .= "1=12,4=109 >i "; 380 } I've already tested it using yaz-client and it worked a treat. It's an undocumented feature that Adam told me about in the Github issues: https://github.com/indexdata/idzebra/issues/37 I don't know if we want to undo the XSLT changes or keep them and do the Perl change as well. It might be worth doing if only to document what the change would be. It might be useful in other sorting contexts as well... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #36 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #33)
Backported to 22.05.x for 22.05.06
I don't think that this has gone out yet, so we could actually still revert these changes too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #37 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #29)
Happy to add a motivational sign-off, but:
I wonder how we can make sure this feature works correctly for updated installations.
1) We should add a note to the release notes about this requiring to reindex.
If we replace the workaround using bug 31756, we won't need to require a reindex! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #38 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #37)
(In reply to Katrin Fischer from comment #29)
Happy to add a motivational sign-off, but:
I wonder how we can make sure this feature works correctly for updated installations.
1) We should add a note to the release notes about this requiring to reindex.
If we replace the workaround using bug 31756, we won't need to require a reindex!
Actually, it looks like that may just be true for MARC21. It looks like "Local-number:s" was added for UNIMARC, so they'll probably still need to re-index... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #38)
(In reply to David Cook from comment #37)
(In reply to Katrin Fischer from comment #29)
Happy to add a motivational sign-off, but:
I wonder how we can make sure this feature works correctly for updated installations.
1) We should add a note to the release notes about this requiring to reindex.
If we replace the workaround using bug 31756, we won't need to require a reindex!
Actually, it looks like that may just be true for MARC21. It looks like "Local-number:s" was added for UNIMARC, so they'll probably still need to re-index...
It makes sense, but since this has been pushed to stable and we are already close to release we need to hurry up if we want to revert and replace with an alternative solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31756 [Bug 31756] Biblionumber not numerically sorting natively when using Zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23875 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org