https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 --- Comment #1 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 180825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180825&action=edit Bug 39610: Make ILL request metadata fields shown in OPAC table configurable Test plan: 1. In KTD, go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=master+switch and enable the ILL module 2. Run the following script to populate the request list for user `koha`: use strict; use warnings; use Koha::ILL::Request; my $backend = 'Standard'; my $branchcode = 'CPL'; for my $n (1..100) { my $req = Koha::ILL::Request->new->load_backend($backend); my $fields = $req->_backend->_get_core_fields(); my @extended_attributes = map { +{ type => $_, value => "$_ for $n" } } keys %$fields; $req->_backend->create_api({ backend => $backend, branchcode => $branchcode, borrowernumber => 51, type => 'book', extended_attributes => \@extended_attributes, }, $req); } 3. Navigate to http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, log in as `koha` as needed 4. Observe only the default Author and Title being displayed 5. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLOpacMetadataFields and set `author|article_author(Article Author)` as the new value 6. On http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, observe how the configured metadata values are now shown, with configured names Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k Depends on| |39600 Assignee|koha-bugs@lists.koha-commun |tadeusz@sosnierz.com |ity.org | --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi Tadeusz, thank you for this work. Please change the bug status to 'Needs Sign-off' if patch ready to be looked at or 'In Discussion' if it's just a PoC that you want feedback on (either status should be fine tbh) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 [Bug 39600] Paginate (and modernize) OPAC ILL requests table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to HKS3 Tadeusz Sośnierz from comment #2)

I'm not super-stoked on manipulating dataTables definition with TT, I'd be curious to hear your ideas for alternatives.

I wouldn't worry too much about manipulating dataTables definition with TT, it's an established pattern utilized elsewhere (see patron-search.inc). I like the idea here but we're losing i18n. Previously, the 'Author' and 'Title' - even though hardcoded - were translatable. Now, we're relying on the table column headers to be inserted directly in the syspref within parenthesis, which works, but doesn't look ideal, and certainly not translatable. See bug 38339, it's making the display names of the attributes translatable. Even though that can't be applied here directly (because we don't have an ILL request - to know its backend - when defining the table column headers) I feel like using that in some way could be an option? I'm not sure, but I don't have a better idea at the moment either! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180825|0 |1 is obsolete| | --- Comment #6 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 181864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181864&action=edit Bug 39610: Make ILL request metadata fields shown in OPAC table configurable Test plan: 1. In KTD, go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=master+switch and enable the ILL module 2. Run the following script to populate the request list for user `koha`: use strict; use warnings; use Koha::ILL::Request; my $backend = 'Standard'; my $branchcode = 'CPL'; for my $n (1..100) { my $req = Koha::ILL::Request->new->load_backend($backend); my $fields = $req->_backend->_get_core_fields(); my @extended_attributes = map { +{ type => $_, value => "$_ for $n" } } keys %$fields; $req->_backend->create_api({ backend => $backend, branchcode => $branchcode, borrowernumber => 51, type => 'book', extended_attributes => \@extended_attributes, }, $req); } 3. Navigate to http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, log in as `koha` as needed 4. Observe only the default Author and Title being displayed 5. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLOpacMetadataFields and set `author|article_author(Article Author)` as the new value 6. On http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, observe how the configured metadata values are now shown, with configured names Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 --- Comment #8 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Rebased on main and added best-effort translations. The extra-configured names will of course not be translated (unless they match some "stock" available translations). I also noticed here that some translations that could be used here are only available in -staff-prog.po, so won't show up here – I'm not sure what the process is for maximizing their availability. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181864|0 |1 is obsolete| | --- Comment #10 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 183153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183153&action=edit Bug 39610: Make ILL request metadata fields shown in OPAC table configurable Test plan: 1. In KTD, go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=master+switch and enable the ILL module 2. Run the following script to populate the request list for user `koha`: use strict; use warnings; use Koha::ILL::Request; my $backend = 'Standard'; my $branchcode = 'CPL'; for my $n (1..100) { my $req = Koha::ILL::Request->new->load_backend($backend); my $fields = $req->_backend->_get_core_fields(); my @extended_attributes = map { +{ type => $_, value => "$_ for $n" } } keys %$fields; $req->_backend->create_api({ backend => $backend, branchcode => $branchcode, borrowernumber => 51, type => 'book', extended_attributes => \@extended_attributes, }, $req); } 3. Navigate to http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, log in as `koha` as needed 4. Observe only the default Author and Title being displayed 5. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLOpacMetadataFields and set `author|article_author(Article Author)` as the new value 6. On http://localhost:8080/cgi-bin/koha/opac-illrequests.pl, observe how the configured metadata values are now shown, with configured names Sponsored-by: Wiko (https://www.wiko-berlin.de/) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 --- Comment #12 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 183155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183155&action=edit Bug 39610: Add SQL bits for ILLOpacMetadataFields -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 --- Comment #14 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 183311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183311&action=edit Bug 39610: Attempt to translate customized metadata headers Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39610 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.