[Bug 33154] New: Tab WRAPPER follow-up: label text must be translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Bug ID: 33154 Summary: Tab WRAPPER follow-up: label text must be translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32571 The new WRAPPER system for building tabs has the unwanted side-effect of creating a situation where text is not translatable. Because the translation process looks for text inside HTML tags, the string "Server information" will not be picked up for translation: [% WRAPPER tab_item tabname= "about" bt_active= 1 %] Server information [% END %] Strings must be wrapped in <span> (or some variation of "[% t('A translatable string') %]." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147835&action=edit Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147835|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148695&action=edit Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148695|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149326&action=edit Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA tools show this warning, but I think it's irrelevant here: * Commit title does not contain 'follow-up' correctly spelt - b9bdec4b71 This might conflict with bug 33332. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149326|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149592&action=edit Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 22.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Bug 33154 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Bug 33154 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org