[Bug 26080] New: Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Bug ID: 26080 Summary: Use the task queue for the batch delete records tool Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107483&action=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107484&action=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107485&action=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20271 URL| |https://gitlab.com/joubu/Ko | |ha/-/commits/bug_26080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak@inLibro.com --- Comment #4 from Hakam Almotlak <hakam.almotlak@inLibro.com> --- patch does not apply error: sha1 information is lacking or useless (Koha/BackgroundJob.pm). error: could not build fake ancestor Patch failed at 0001 Bug 26080: Use the task queue for batch delete biblios hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-26080-Use-the-task-queue-for-batch-delete-bibl-KTCIJD.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107483|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122347&action=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107484|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122348&action=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107485|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122349&action=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|hakam.almotlak@inLibro.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122347|0 |1 is obsolete| | Attachment #122348|0 |1 is obsolete| | Attachment #122349|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123214&action=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123215&action=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123216&action=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27526 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28149 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123214|0 |1 is obsolete| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123989&action=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123215|0 |1 is obsolete| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123990&action=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123216|0 |1 is obsolete| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123991&action=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Works super. I hope we will see all task queue refactoring in 21.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #14)
Works super. I hope we will see all task queue refactoring in 21.11
Test the other patches and make it happen! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124408&action=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124409&action=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124410&action=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124411&action=edit Bug 26080: (QA follow-up) Minor template issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124412&action=edit Bug 26080: (QA follow-up) Add POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29149 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 [Bug 29149] Background job detail view needs more flexibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Bug 26080 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org