[Bug 10010] New: Use jQueryUI Accordion to display constraints in MARC subfield editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Bug ID: 10010 Summary: Use jQueryUI Accordion to display constraints in MARC subfield editor Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add _form&tagfield=X&frameworkcode=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org CC: gmcharlt@gmail.com Created attachment 17310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17310&action=edit Screenshot of proposed revised interface Display of the three sections of subfield constraints (basic, advanced, and other) is well-suited to the jQueryUI Accordion widget. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17312&action=edit Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17312|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17382&action=edit Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17679&action=edit Bug 10010: Problems with diacritics in saved SQL reports Adds decoding for cgi params (for completeness). Apparently, the NAME attribute of DBI statement handle has a UTF8 bug. Fixing this by decoding the returned column names. Did this in a shared routine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17679|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 17679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17679 Bug 10010: Problems with diacritics in saved SQL reports Oops wrong report.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17382|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18943&action=edit [SIGNED-OFF] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18943|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19048&action=edit [PASSED QA] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Looks nice, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |katrin.fischer@bsz-bw.de Patch complexity|Small patch |--- --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice work Owen! Can we also get a patch for the authority frameworks? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Katrin, reading the history, it seems you did not mean to switch back to 'Signed Off'. Could you confirm this patch had passed QA? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are right, thx Jonathan! It happens sometimes when using git bz that the status pulldown in bugzilla is still on the old status... then you add a comment and it's resetting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org