[Bug 36074] New: Make materials specified note easier to customize, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Bug ID: 36074 Summary: Make materials specified note easier to customize, part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 35253 made the materials specified note easier to customize. However I failed to realized that the message is slightly different if 'CircConfirmItemParts' is set to 'Require'. That message should also include the HTML classes added for Bug 35253. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162069&action=edit Bug 36074: Add classes to materials specfied message on check in and checkout when CircConfirmItemParts is on. To test: 1. APPLY PATCH 2. Set CircConfirmItemParts to 'Require'. 3. Add a materials specified message to an item. ( 952$3 ) 4. Add the following CSS to your IntranetUserCSS: .mats_spec_label { color: white; background: purple; } .mats_spec_message { color: white; background: green; } 5. Checkout that item. Notice the message should be green and the label (Note about the accompanying materials:) should be purple. 6. Check in that item. Notice the message should be green and the label (Note about the accompanying materials:) should be purple. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162069|0 |1 is obsolete| | --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 162122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162122&action=edit Bug 36074: Add classes to materials specfied message on check in and checkout when CircConfirmItemParts is on. To test: 1. APPLY PATCH 2. Set CircConfirmItemParts to 'Require'. 3. Add a materials specified message to an item. ( 952$3 ) 4. Add the following CSS to your IntranetUserCSS: .mats_spec_label { color: white; background: purple; } .mats_spec_message { color: white; background: green; } 5. Checkout that item. Notice the message should be green and the label (Note about the accompanying materials:) should be purple. 6. Check in that item. Notice the message should be green and the label (Note about the accompanying materials:) should be purple. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Sourav Nag <sourav.nag14@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sourav.nag14@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only adds CSS classes, reviewed closely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #3)
Only adds CSS classes, reviewed closely.
This was meant for another bug. Still only small mark-up changes here. Removed some additional spaces: <span class="mats_spec_label"> Please confirm that the accompanying materials are present: </span> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35253 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35253 [Bug 35253] Make materials specified note easier to customize -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see one last additional space : ... are present:</span> ... are present: </span> Removing it will allow to have online 1 translation :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org