[Bug 20304] New: Warnings in cataloguing scripts need to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Bug ID: 20304 Summary: Warnings in cataloguing scripts need to be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 19996 Since bug 19996 we have now warnings in cataloguing scripts. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 [Bug 19996] use Modern::Perl in cataloguing perl scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 72271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72271&action=edit Bug 20304: Remove warnings from cataloguing scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72271|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 72272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72272&action=edit Bug 20304: Remove warnings from cataloguing scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am going to attach patches when I find these warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 72272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72272 Bug 20304: Remove warnings from cataloguing scripts Review of attachment 72272: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20304&attachment=72272) ----------------------------------------------------------------- ::: cataloguing/additem.pl @@ +157,5 @@
my $temp2 = $temp->field($CNtag); if ($temp2) { + my $value = q{}; + $value .= $temp2->subfield($CNsubfield) if $temp2->subfield($CNsubfield); + $value .= $temp2->subfield($CNsubfield2) if $temp2->subfield($CNsubfield2);
Where's the space gone? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72272|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73522&action=edit Bug 20304: Remove warnings from cataloguing scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #4)
Comment on attachment 72272 [details] [review] Bug 20304: Remove warnings from cataloguing scripts
Review of attachment 72272 [details] [review]: -----------------------------------------------------------------
::: cataloguing/additem.pl @@ +157,5 @@
my $temp2 = $temp->field($CNtag); if ($temp2) { + my $value = q{}; + $value .= $temp2->subfield($CNsubfield) if $temp2->subfield($CNsubfield); + $value .= $temp2->subfield($CNsubfield2) if $temp2->subfield($CNsubfield2);
Where's the space gone?
lost, but I found it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73522|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73869&action=edit Bug 20304: Remove warnings from cataloguing scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Set a default value for the holding branch in the default framework. Add a manual record using the default framework. In order to trigger all the code, I needed a value in 082$a I then put crazy long values (>100) in text fields for the item and saved. I made sure the full call number was set to something (I used 100$ab). So yes, my data is horrible, but having triggered all the code, I know it works. :) And so much less floody. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73869|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73961&action=edit Bug 20304: Remove warnings from cataloguing scripts Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73961|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 74876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74876&action=edit Bug 20304: Remove warnings from cataloguing scripts Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 74877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74877&action=edit Bug 20304: (QA follow-up) Remove unwanted 'my' 'my' creates a new '$value' variable, and prevented the '$value' in outer scope to be modified Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org