[Bug 5521] New: item edit form appears if no items found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Summary: item edit form appears if no items found Change sponsored?: --- Product: Koha Version: HEAD Platform: All URL: /cgi-bin/koha/tools/batchMod.pl OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Created attachment 2884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2884 edit of no items When using the batch edit tool if you get no items found you still get the edit item form. If there are no items found there shouldn't be a form to edit them :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13117&action=edit Bug 5521 - item edit form appears if no items found This patch changes the template so that if no items are found the page doesn't show "The following barcodes were found" and doesn't show the item edit form. To test, submit a batch which contains no valid barcodes. Compare to a batch which contains some or all valid barcodes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13117|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 13143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13143&action=edit [SIGNED-OFF] Bug 5521 - item edit form appears if no items found This patch changes the template so that if no items are found the page doesn't show "The following barcodes were found" and doesn't show the item edit form. To test, submit a batch which contains no valid barcodes. Compare to a batch which contains some or all valid barcodes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests succeed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- String changes. Will hold for post-3.10.0. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * template only change * passes koha-qa.pl * introduces a new string, but it's displayed only in some specific cases (when there is no item found), so I think it's OK for 3.10.0, because the messages before this patch may be of some trouble for users. So, between a troubling (frenchism ?) message and an uncommon english message, I prefer the former. passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13143|0 |1 is obsolete| | --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13404&action=edit Bug 5521 - item edit form appears if no items found This patch changes the template so that if no items are found the page doesn't show "The following barcodes were found" and doesn't show the item edit form. To test, submit a batch which contains no valid barcodes. Compare to a batch which contains some or all valid barcodes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests succeed. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|3.12 |3.10 QA Contact|koha-bugs@lists.koha-commun |paul.poulain@biblibre.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |3.12 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #4)
* introduces a new string, but it's displayed only in some specific cases (when there is no item found), so I think it's OK for 3.10.0, because the messages before this patch may be of some trouble for users. So, between a troubling (frenchism ?) message and an uncommon english message, I prefer the former.
I disagree. It will break not only the French translation but also translations for the other 43 languages that Koha has been translated into. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #6)
(In reply to comment #4)
* introduces a new string, but it's displayed only in some specific cases (when there is no item found), so I think it's OK for 3.10.0, because the messages before this patch may be of some trouble for users. So, between a troubling (frenchism ?) message and an uncommon english message, I prefer the former.
I disagree. It will break not only the French translation but also translations for the other 43 languages that Koha has been translated into.
I agree/know it will break all translation (the "frenchism?" was refering to the word "troubling", that I'm not sure is English) But the added string appears only under uncommon circumstances, while a string appearing more frequently is removed. Thus my comment it should be for 3.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|3.12 |3.10 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Now the string freeze is passed, this can be pushed to 3.10.x will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5521 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #11 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Pushed to 3.6.x will be in 3.6.11. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org