https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42507 Bug ID: 42507 Summary: Recall pickup slip popup blocked by browser after 'Print slip and confirm' is clicked on recall modal Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Depends on: 42505 The recall print-slip flow has the same browser popup-blocker problem fixed for hold slips in bug 42505. In koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt the .print-recall click handler sets a hidden recall_slip=1 input and submits the form. circ/returns.pl reads that param and sets the recall_slip template variable on the response page. The response page then calls Dopop('/cgi-bin/koha/recalls/recall_pickup_slip.pl?recall_id=...') from \$(document).ready (via 'if (recall_slip) Dopop(...)') â long after the user gesture has expired. Modern browsers block that window.open() as an unsolicited popup. The recall is confirmed but the slip never appears. Reproduction ============ 1. Place a recall on an item (RecallsEnabled etc. configured). 2. Check in the item; the 'Recall found' modal appears. 3. Click 'Print slip and confirm' (the .print-recall button). 4. Expected: recall is confirmed and the recall pickup slip opens in a new window. 5. Actual: the recall is confirmed but the slip popup is blocked by the browser. Suggested fix ============= Mirror the bug 42505 approach: open the recall pickup slip synchronously inside the .print-recall click handler using the recall_id available in the form, so the window.open() remains tied to the user gesture. Then submit the form to confirm the recall. This avoids the document.ready Dopop chain and the popup blocker. Depends on bug 42505 to keep the fixes consistent. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42505 [Bug 42505] Hold transfer slip popup blocked by browser after 'Print slip and confirm' is clicked on hold-found modal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.