https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 161797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161797&action=edit Bug 36013: update_totalissues.pl should not log Even when CataloguingLog is on, misc/cronjobs/update_totalissues.pl should not log the changes. It is useless and takes database space. Do like bulkmarcimport.pl : https://git.koha-community.org/Koha-community/Koha/src/branch/23.11.x/misc/m... Test plan : 1) Enable system preference CataloguingLog 2) Perform some issues and returns 3) Run : misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v 4) Go to Tools > Log viewer 5) Check there are no new cataloguing logs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10326 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- I had a problem where a bad record would stop the script from completing: $ misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v Processing bib 1 (0 issues) Processing bib 2 (0 issues) Processing bib 3 (0 issues) ... Processing bib 368 (0 issues) Processing bib 369 (0 issues) :8: parser error : PCDATA invalid Char value 31 <controlfield tag="001">00aD000015937</controlfield> ^ :9: parser error : PCDATA invalid Char value 31 <controlfield tag="004">00satmrnu0</controlfield> ^ :9: parser error : PCDATA invalid Char value 31 <controlfield tag="004">00satmrnu0</controlfield> ^ :9: parser error : PCDATA invalid Char value 31 <controlfield tag="004">00satmrnu0</controlfield> ^ :9: parser error : PCDATA invalid Char value 31 <controlfield tag="004">00satmrnu0</controlfield> ^ :10: parser error : PCDATA invalid Char value 31 <controlfield tag="008">00ar19881981bdkldan</controlfield> After deleting that record the script runs as it should: ... Processing bib 437 (0 issues) Processing bib 438 (0 issues) Update total issues count script report ======================================================= Run started at: 03/08/24 11:48:53 Run ended at: 03/08/24 11:48:57 Total run time: 4751 ms Number of bibs modified: 435 Number of bibs with error: 0 After this the cataloguing log shows one entry per record, so that will quickley amount to a lot of unnecessary data! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161797|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Created attachment 162957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162957&action=edit Bug 36013: update_totalissues.pl should not log Even when CataloguingLog is on, misc/cronjobs/update_totalissues.pl should not log the changes. It is useless and takes database space. Do like bulkmarcimport.pl : https://git.koha-community.org/Koha-community/Koha/src/branch/23.11.x/misc/m... Test plan : 1) Enable system preference CataloguingLog 2) Perform some issues and returns 3) Run : misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v 4) Go to Tools > Log viewer 5) Check there are no new cataloguing logs Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Before the patch, running the script adds one entry to action_logs per record, with the patch nothing is logged. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates logging when release notes| |the | |misc/cronjobs/update_totali | |ssues.pl script is run and | |CataloguingLog is enabled). | |This previously added one | |entry to the log for each | |record updated - this | |information is not useful | |and can take up a lot of | |database space. --- Comment #6 from David Nind <david@davidnind.com> --- THanks Magnus! Have added my sign off in case that helps with getting through QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36474 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36013 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- I will try to see if there are other scripts with similar arg -- You are receiving this mail because: You are watching all bug changes.