http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14983&action=edit Bug 9520 - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14983|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15004&action=edit [SIGNED-OFF] Bug 9520 - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The query is not the good one, mysql raises a warning: Data truncated for column 'type' at row 4 type is an enum (cf kohastructure: `type` enum('zed','opensearch') NOT NULL default 'zed') Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #4)

Sorry but.. did the comment applies to this bug?

Yes! mysql> show create table z3950servers; [...] `type` enum('zed','opensearch') NOT NULL DEFAULT 'zed', [...] mysql> UPDATE z3950servers SET host = 'lx2.loc.gov', port = 210, db = 'LCDB', type = 'USMARC', encoding = 'utf8' WHERE name = 'LIBRARY OF CONGRESS'; Query OK, 0 rows affected, 1 warning (0.06 sec) Rows matched: 1 Changed: 0 Warnings: 1 mysql> show warnings; +---------+------+-------------------------------------------+ | Level | Code | Message | +---------+------+-------------------------------------------+ | Warning | 1265 | Data truncated for column 'type' at row 4 | +---------+------+-------------------------------------------+ 1 row in set (0.00 sec) mysql> select type from z3950servers where name='LIBRARY OF CONGRESS'; +------+ | type | +------+ | | +------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15004|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15769&action=edit Bug 9520 -[Revised] - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. Revision: Was trying to update wrong column 'type', now correct column 'syntax'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #8)

(In reply to comment #6)

...

Bug 9494 does not update the type column. It doesn't need to. The correct column to update is 'syntax'. I was fooled by the name. I'm sorry (again).

Don't worry, thanks for your quick revised patch! Now it is good. This patch updates the LOC z3950 server for current installations. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.