[Bug 9574] New: serials/subscription-add.pl does not work right under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Bug ID: 9574 Summary: serials/subscription-add.pl does not work right under Plack Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jcamins@cpbibliography.com When editing a subscription under Plack, the area for entering manual history appears regardless of whether you enabled manual history or not. I also get the following warnings in the log, one of which, presumably, is related to the problem: Use of uninitialized value $firstissuedate in string eq at /home/jcamins/kohaclone/serials/subscription-add.pl line 92. Use of uninitialized value $firstissuedate in substr at /home/jcamins/kohaclone/serials/subscription-add.pl line 105. Use of qw(...) as parentheses is deprecated at /home/jcamins/kohaclone/serials/subscription-add.pl line 95. Subroutine letter_loop redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 180. Subroutine _get_sub_length redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 195. Subroutine redirect_add_subscription redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 205. Variable "$firstissuedate" is not available at /home/jcamins/kohaclone/serials/subscription-add.pl line 338. Subroutine redirect_mod_subscription redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 274. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Actually, the area for entering manual history always shows up, regardless whether you're running under Plack or not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 15209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15209&action=edit Bug 9574: Plack fixes for serials/subscription-add.pl This patch fixes the following warnings under Plack: * Use of uninitialized value $firstissuedate in string eq at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 92. * Use of uninitialized value $firstissuedate in substr at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 105. * Use of qw(...) as parentheses is deprecated at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 95. * Variable "$firstissuedate" is not available at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 338. To test: 1) Create a subscription. Ensure that setting the first issue's publication date works. 2) Edit a subscription. Ensure that the first issue's publication date shows up. 3) Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The manual history block showing up was already reported as bug 7608. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15209|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15314&action=edit Bug 9574: Plack fixes for serials/subscription-add.pl This patch fixes the following warnings under Plack: * Use of uninitialized value $firstissuedate in string eq at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 92. * Use of uninitialized value $firstissuedate in substr at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 105. * Use of qw(...) as parentheses is deprecated at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 95. * Variable "$firstissuedate" is not available at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 338. To test: 1) Create a subscription. Ensure that setting the first issue's publication date works. 2) Edit a subscription. Ensure that the first issue's publication date shows up. 3) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15314|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15876&action=edit [PASSED QA] Bug 9574: Plack fixes for serials/subscription-add.pl This patch fixes the following warnings under Plack: * Use of uninitialized value $firstissuedate in string eq at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 92. * Use of uninitialized value $firstissuedate in substr at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 105. * Use of qw(...) as parentheses is deprecated at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 95. * Variable "$firstissuedate" is not available at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 338. To test: 1) Create a subscription. Ensure that setting the first issue's publication date works. 2) Edit a subscription. Ensure that the first issue's publication date shows up. 3) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No regressions found, all tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org