[Bug 15109] New: Regression in patron search results ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Bug ID: 15109 Summary: Regression in patron search results ordering Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44288&action=edit Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44288|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 44296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44296&action=edit Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Followed test plan. Worked as expecting (after a browser reload). Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Marc you forgot to change bug status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7349 CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is already a DT sort parameter in the template: 'aaSorting': [[1, 'asc']], This one should be modified. Moreover this script does not check for the existence of the checkboxes in the first column ([% IF CAN_user_tools_manage_patron_lists %]), which places the cardnumber in 0 or 1. I will provide a counter patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44296|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44829&action=edit Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44830&action=edit Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44829|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44854&action=edit Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44830|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44855&action=edit Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15196 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44854|0 |1 is obsolete| | Attachment #44855|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44892&action=edit [PASSED QA] Bug 15109 - Regression in patron search results ordering In Koha 3.16 or earlier, before the introduction of the ajax datatable for patron searching, the search results were ordered by name. In master, the results are currently ordered by cardnumber, which is not very useful. Test Plan: 1) Do a "browse by last name" or a patron search 2) Note the results are sorted by card number 3) Apply this patch 4) Reload the page, start a new search 5) Note the results are sorted by name Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44893&action=edit [PASSED QA] Bug 15109: Make name the default sort order for all patron searches Find another place where there is a patron search (add user to a basket, add users to a fund or edit owner of a fund, set a guarantor to a child, etc.). Do a search a confirm that the results are now sorted by name instead of cardnumber. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15109 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |liz@catalyst.net.nz --- Comment #13 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org