[Bug 27428] New: Show the number of records in the bibliographic record detail page with ElasticSearch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Bug ID: 27428 Summary: Show the number of records in the bibliographic record detail page with ElasticSearch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: ivan.dziuba@inlibro.com This preference only for OPAC to show the number of records next to search links in the bibliographic record detail page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #1 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 115159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115159&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ivan.dziuba@inlibro.com |ity.org | CC| |eric.begin@inLibro.com, | |ivan.dziuba@inlibro.com, | |philippe.blouin@inlibro.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115159|0 |1 is obsolete| | --- Comment #2 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 115206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115206&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Bug 27428: Show the number of records in the bibliographic. Update code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen@ub.lu.se Status|Needs Signoff |In Discussion --- Comment #3 from Frank Hansen <frank.hansen@ub.lu.se> --- I have applied the patch but I can't get it to work. Maybe I misunderstand how it is supposed to work. Can you clarify what it should look like, maybe post a screen shots? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I see an error in the console: Could not compile /kohadevbox/koha/opac/svc/elasticsearch/opac-autocomplete.pl: Can't locate Switch.pm in @INC (you may need to install the Switch module) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timothy_alexis.vass@ub.lu.s | |e --- Comment #5 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- I see this line in the patch for opac/svc/elasticsearch/opac-autocomplete.pl: 8 use Switch; But it doesn't seem to be used in the code? There seems to be other modules used which aren't used either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #6 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Sorry, the Switch module is the only one which isn't actually used in the code. There are no switch or case statements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen@ub.lu.se --- Comment #7 from Björn Nylén <bjorn.nylen@ub.lu.se> --- I recall dependency on Text::Unaccent was recently removed by Bug 14759, replaced by Unicode::Normalize. We shouldn't ad it back in, perhaps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115206|0 |1 is obsolete| | --- Comment #8 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 117950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117950&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Remove Switch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #9 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Frank Hansen from comment #3)
I have applied the patch but I can't get it to work. Maybe I misunderstand how it is supposed to work. Can you clarify what it should look like, maybe post a screen shots?
Same as Franck, I don't see differents in bib record page when I enable the syspref. It seems I misunderstood something too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117950|0 |1 is obsolete| | --- Comment #10 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 119980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119980&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Bug 27113: ElasticSearch: Autocomplete in input search. Use Unicode::Normalize instead Text::Unaccent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- This patch includes elasticsearch/opac-autocomplete.pl. Does that change belong here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #12 from Blou <philippe.blouin@inlibro.com> --- That shoudl be opac-elasticsearch.pl (or similar generic name) in here and Bug 27113 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119980|0 |1 is obsolete| | --- Comment #13 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 120034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120034&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Lund University Sandbox <lubcat@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120034|0 |1 is obsolete| | --- Comment #14 from Lund University Sandbox <lubcat@ub.lu.se> --- Created attachment 120633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120633&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stina.hallin@ub.lu.se --- Comment #15 from Stina Hallin <stina.hallin@ub.lu.se> --- The number of records did show, but some of the search words got the number 0, and that is obviously wrong. See: Subject(s): Clans -- Scotland -- Great Glen -- History -- 17th century [1] | Clans -- Scotland -- Great Glen -- History -- 18th century [1] | Jacobites [2] | Great Glen (Scotland) -- History [1] | Highlands (Scotland) -- History [0] | Scotland -- History -- 17th century [1] | Scotland -- History -- 18th century [0]
From opac-detail.pl?biblionumber=60.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Stina Hallin from comment #15)
The number of records did show, but some of the search words got the number 0, and that is obviously wrong. See: Subject(s): Clans -- Scotland -- Great Glen -- History -- 17th century [1] | Clans -- Scotland -- Great Glen -- History -- 18th century [1] | Jacobites [2] | Great Glen (Scotland) -- History [1] | Highlands (Scotland) -- History [0] | Scotland -- History -- 17th century [1] | Scotland -- History -- 18th century [0] From opac-detail.pl?biblionumber=60.
Stina, if you find things that are obviously wrong, you may change the status of the patch to Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +('OPACDisplayRecordCount','0',NULL,NULL,'YesNo') Please add description here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + default: no + choices: + 1: Show + 0: "Don't show" You probably mean default 0 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120633|0 |1 is obsolete| | --- Comment #19 from shi-yao.wang@inLibro.com --- Created attachment 132068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132068&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #20 from Séverine Queune <severine.queune@bulac.fr> --- Ok, I got it now ! It works nice :) I've got few questions though before signing it. I wonder what is the perimeter of the application : does the feature applied for every search link available in the record ? I saw that some special signs are not taken into account in the search but some are kept such like ';' or ':'. Is it a specific reason for that, for I don't get the logic ? This special signs can lead to unsuccessful searches so, for some records with a lot of informations, I wonder if, in the case result is [0], it's useful to display the information (see screenshot https://snipboard.io/RvlewS.jpg) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132068|0 |1 is obsolete| | --- Comment #21 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139625&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139625|0 |1 is obsolete| | --- Comment #22 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139626&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139626|0 |1 is obsolete| | --- Comment #23 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 139681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139681&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 solene.ngamga@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 solene.ngamga@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139681|0 |1 is obsolete| | --- Comment #24 from solene.ngamga@inlibro.com --- Created attachment 145222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145222&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL Koha/SearchEngine/Elasticsearch/Browse.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'count_record' SKIP spelling OK valid OK installer/data/mysql/mandatory/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc FAIL filters asset_must_be_raw at line 52 ( [% Asset.js("js/opac-display-record-count.js") %]) OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/js/opac-display-record-count.js FAIL ES template literals ES template literals found ( var regex = `a[href*="${regex_es_link}"]`;) - See bug 24725 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #26 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 148842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148842&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145222|0 |1 is obsolete| | --- Comment #27 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 154509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154509&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148842|0 |1 is obsolete| | --- Comment #28 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 154510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154510&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de Summary|Show the number of records |Show the number of records |in the bibliographic record |in the bibliographic record |detail page with |detail page with |ElasticSearch. |ElasticSearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |michaela.sieber@kit.edu --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, this is a really interesting feature! Some notes: 1) The QA test tools are currently still failing, but it's only a perltidy that is needed. 2) The database update still has the old format and should be moved to the newer atomic update template. 3) The system preference is added correctly, but should a) Include a note that this feature is "Elasticsearch only" b) Be moved to the "Features" section instead of the "Did you mean" where it appears now. 4) It didn't work in my testing :( Maybe something broke with changes made to the OPAC since this was submitted the first time? * I used ktd --es7 up * Made sure SearchEngine was Elasticsearch and search worked * Applied patch * restart_all * Turned on OPACDisplayRecordCount system preference I don't see any errors in the console, but the JSON responses come back empty, possibly because the q param is empty:: http://localhost:8080/cgi-bin/koha/svc/elasticsearch/opac-elasticsearch.pl?q=[]&key=nb_notice ? I searched for "perl" in a MARC21 sample database and paged through a lot of the results with no counts showing. 5) Code review * Please translate code comments if you want to keep them: +/* Regex pour tous les URL avec un recherche */ This uses the older /svc pattern, we might want to get a second more technical review on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154509|0 |1 is obsolete| | --- Comment #30 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 158639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158639&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154510|0 |1 is obsolete| | --- Comment #31 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 158640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158640&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #32 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 158641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158641&action=edit Bug 27428: (follow-up) perltidy, change the atomic file to the newer format, moving system preference to Features section and Fixing opac-display-record-count.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #33 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 161349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161349&action=edit Bug 27428: (follow-up) Fix Session -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158639|0 |1 is obsolete| | --- Comment #34 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 164557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164557&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158640|0 |1 is obsolete| | --- Comment #35 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 164558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164558&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158641|0 |1 is obsolete| | --- Comment #36 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 164559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164559&action=edit Bug 27428: (follow-up) perltidy, change the atomic file to the newer format, moving system preference to Features section and Fixing opac-display-record-count.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161349|0 |1 is obsolete| | --- Comment #37 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 164560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164560&action=edit Bug 27428: (follow-up) Fix Session -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #38 from David Nind <david@davidnind.com> --- Created attachment 167328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167328&action=edit Screenshot - display for record detail page - [[object Object]] For me, [[object Object]] is being displayed instead of the number of records. I've attached a screenshot of what I'm seeing. I also did a complete reindex (not sure whether this is necessary). Other things I noted: 1. OPACDisplayRecordCount is still listed under the "Did you mean/spell checking" section, rather than "Features" 2. Should the description have a note saying only for Elasticsearch/Open Search? 3. If search engine is Zebra, is currently showing the [[object Object]] Testing notes (using KTD): 1. Start up KTD with Elasticsearch: ktd --es8 up or ktd --es7 up 2. Apply the patch 3. Update the database: updatedatabase 4. Restart everything: flush_memcached and restart_all 5. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #39 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 167677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167677&action=edit Bug 27428: (follow-up) show the number instead [[object Object]], move OPACDisplayRecordCount to the 'Features' section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164557|0 |1 is obsolete| | --- Comment #40 from David Nind <david@davidnind.com> --- Created attachment 167767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167767&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164558|0 |1 is obsolete| | --- Comment #41 from David Nind <david@davidnind.com> --- Created attachment 167768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167768&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164559|0 |1 is obsolete| | --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 167769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167769&action=edit Bug 27428: (follow-up) perltidy, change the atomic file to the newer format, moving system preference to Features section and Fixing opac-display-record-count.js Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164560|0 |1 is obsolete| | --- Comment #43 from David Nind <david@davidnind.com> --- Created attachment 167770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167770&action=edit Bug 27428: (follow-up) Fix Session Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167677|0 |1 is obsolete| | --- Comment #44 from David Nind <david@davidnind.com> --- Created attachment 167771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167771&action=edit Bug 27428: (follow-up) show the number instead [[object Object]], move OPACDisplayRecordCount to the 'Features' section Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167328|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #45 from David Nind <david@davidnind.com> --- Created attachment 167774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167774&action=edit Bug 27428: (follow-up) Update system preference description Add Elasticsearch only to OPACDisplayRecordCount description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #46 from David Nind <david@davidnind.com> --- I added a follow-up to update the new system preference description to indicate that it is Elasticsearch only. I got a bit confused when signing off - if I started up KTD with Elasticsearch, it worked as expected. If I switched the search engine to Zebra, rebuilt the index, and restarted everything, it was showing the counts in the OPAC. However, if I started up KTD without Elasticsearch it did not display the counts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #47 from David Nind <david@davidnind.com> --- Some more comments, but not something I'm sure of any more - so will leave to the QA team: 1. The change using the <b> tag for the count, I think we should be using <strong> to make the count bold. 2. Maybe a class should be used for the count style, so that libraries can customise the CSS. For some, the count in black and bold may stand out a little too much on the page (it does for me). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #48 from David Cook <dcook@prosentient.com.au> --- Can someone explain the bug title? "Show the number of records in the bibliographic record" doesn't make sense to me. Is that supposed to be "Show the number of item records"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #49 from David Cook <dcook@prosentient.com.au> --- Is this a brand new development or is this something inLibro has had around for a while? I haven't read through everything here, but noticing some issues. While we don't explicitly have a coding guideline for this, we shouldn't be adding new "svc" scripts. API calls should be added via the REST API. I see that "opac/svc/elasticsearch/opac-elasticsearch.pl" doesn't have any authentication or authorization (even if it's a public endpoint, this is needed for appropriate session handling at the very least), and has completely non-standard output. It's also not clear to me why you're using Unicode::Normalize here. The "not_symbols" bit in "koha-tmpl/opac-tmpl/bootstrap/js/opac-display-record-count.js" is also weird. I could be missing something but I have a feeling that something isn't right here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #50 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 167770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167770 Bug 27428: (follow-up) Fix Session Review of attachment 167770: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27428&attachment=167770) ----------------------------------------------------------------- ::: opac/svc/elasticsearch/opac-elasticsearch.pl @@ +10,4 @@
my $browser = Koha::SearchEngine::Elasticsearch::Browse->new( { index => 'biblios' } ); my $cgi = CGI->new; +my $session = CGI::Session->load() or die CGI::Session->errstr();
This isn't how we do this in Koha. This is also why you'd use something like check_api_auth() (not that you should be doing a "svc" script at all), as you'd get a $sessionID that you could then use with C4::Auth::get_session($sessionID). But really this should be a REST API endpoint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #51 from David Cook <dcook@prosentient.com.au> --- Apologies if I sound grumpy. It's not my intention. It's first thing Monday morning 😅. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #48)
Can someone explain the bug title? "Show the number of records in the bibliographic record" doesn't make sense to me. Is that supposed to be "Show the number of item records"?
I think it's probably a hard one to explain in a short phrase. What it means is: Show the number of records you will find, when clicking on that search link in the record. I know libraries would love this especially for the 7xx/8xx linkings (how many linked volumes? how many analytics?) but also cool for subjects to see which search route is the most promising. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #53 from Blou <philippe.blouin@inlibro.com> --- You do sound grumpy :) but I can justify the current state of affair. Katryn already explained the functionality. We coded that many years ago along Bug 27113. We asked the community HOW to do it to avoid exactly this type of comment (which I don't mind in essence, but the timing is off). As usual, the target kept moving. We tried to share code between the two bz, or at least architecture. But Bug 27113 got blocked by another one. Your points are probably all valid, but until Bug 27113 (autocomplete) gets moving, were not going to rearchitecture this one as we don't want this little feature complicating our future development of the big one. We rebase to keep it valid for the libraries who want it, and to give it to our users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #54 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #52)
(In reply to David Cook from comment #48)
Can someone explain the bug title? "Show the number of records in the bibliographic record" doesn't make sense to me. Is that supposed to be "Show the number of item records"?
I think it's probably a hard one to explain in a short phrase. What it means is: Show the number of records you will find, when clicking on that search link in the record.
I know libraries would love this especially for the 7xx/8xx linkings (how many linked volumes? how many analytics?) but also cool for subjects to see which search route is the most promising.
I wouldn't have guessed that, so thanks for the explanation! That's interesting! Seems like it could be difficult to do in a high performance way... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #55 from David Cook <dcook@prosentient.com.au> --- (In reply to Blou from comment #53)
You do sound grumpy :)
Haha thanks for the confirmation :)
We coded that many years ago along Bug 27113. We asked the community HOW to do it to avoid exactly this type of comment (which I don't mind in essence, but the timing is off). As usual, the target kept moving.
Thanks for mentioning that. I had a feeling that was probably the case, but wanted to check.
We tried to share code between the two bz, or at least architecture. But Bug 27113 got blocked by another one.
Your points are probably all valid, but until Bug 27113 (autocomplete) gets moving, were not going to rearchitecture this one as we don't want this little feature complicating our future development of the big one.
Fair enough. I am still curious about the use of Unicode::Normalize here though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #56 from Blou <philippe.blouin@inlibro.com> --- I didn't code it, but my first instinct would be that it's related to Bug 27113, again. You don't want to bother with accents when comparing for an autocomplete. I read in another comment you suggest using Unicode::Collate::Locale instead of Unicode::Normalize, and hopefully it'll be caught whenever a "real" release is done for either patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27113 Status|Failed QA |BLOCKED --- Comment #57 from David Cook <dcook@prosentient.com.au> --- (In reply to Blou from comment #56)
I didn't code it, but my first instinct would be that it's related to Bug 27113, again. You don't want to bother with accents when comparing for an autocomplete.
I read in another comment you suggest using Unicode::Collate::Locale instead of Unicode::Normalize, and hopefully it'll be caught whenever a "real" release is done for either patch.
Ah right the autocomplete. Makes sense I think. Overall, I think that you've answered most of my questions. I think the SVC vs REST API question needs to be answered and it looks like that question is mostly being asked in bug 27113, so I think BLOCKED makes sense for a status here. Also adding a dependency on bug 27113. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 [Bug 27113] Elasticsearch: Autocomplete in search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167767|0 |1 is obsolete| | --- Comment #58 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170274&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167768|0 |1 is obsolete| | --- Comment #59 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170275&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167769|0 |1 is obsolete| | --- Comment #60 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170276&action=edit Bug 27428: (follow-up) perltidy, change the atomic file to the newer format, moving system preference to Features section and Fixing opac-display-record-count.js Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167770|0 |1 is obsolete| | --- Comment #61 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170277&action=edit Bug 27428: (follow-up) Fix Session Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167771|0 |1 is obsolete| | --- Comment #62 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170278&action=edit Bug 27428: (follow-up) show the number instead [[object Object]], move OPACDisplayRecordCount to the 'Features' section Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167774|0 |1 is obsolete| | --- Comment #63 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170279&action=edit Bug 27428: (follow-up) Update system preference description Add Elasticsearch only to OPACDisplayRecordCount description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 [Bug 25870] Add a q_ccl query parameter to /biblios -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #64 from David Cook <dcook@prosentient.com.au> --- Actually, if OpacHiddenItems, this count can't be accurate, although the count shown on the Koha results page isn't accurate either, so I suppose that's OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #65 from David Cook <dcook@prosentient.com.au> --- I suspect that the way to get bug 27113 moving would be to put a pause on bug 25870 and bug 27428, since it seems like bug 27113 depends on bug 27428 which depends on bug 25870? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #66 from Blou <philippe.blouin@inlibro.com> --- Bug 27428 and Bug 27113 are actually twin brothers (or sisters), born at the same time, needing the same functionalities in the backend, and we needed to be able to pile them without having to recode (too much). Thus a fake dependency between the two, but they are actually standalone features. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #67 from David Cook <dcook@prosentient.com.au> --- (In reply to Blou from comment #66)
Bug 27428 and Bug 27113 are actually twin brothers (or sisters), born at the same time, needing the same functionalities in the backend, and we needed to be able to pile them without having to recode (too much). Thus a fake dependency between the two, but they are actually standalone features.
I think that I'm starting to understand why things have ground to a halt... hehe. I think one way or another, the SVC API needs to be changed to the REST API, but that should actually be quite easy since the SVC API script is super simple. Personally, I don't see why these features would need bug 25870. If someone feels very strongly that it does, I think that they should write out their reasons/plan somewhere and link to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #68 from Eric Bégin <eric.begin@inLibro.com> --- I agree with David, so I "unlocked" it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Assignee|ivan.dziuba@inlibro.com |hammat.wele@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #69 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Patch doesn't apply. Also, since there is a dependency between Bug 27113 and this one, it applies all the patches for the two bugs. If they are independent, they should not be dependent. We can use "See also" instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170274|0 |1 is obsolete| | --- Comment #70 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 180561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180561&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170275|0 |1 is obsolete| | --- Comment #71 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 180562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180562&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170276|0 |1 is obsolete| | --- Comment #72 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 180563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180563&action=edit Bug 27428: (follow-up) perltidy, change the atomic file to the newer format, moving system preference to Features section and Fixing opac-display-record-count.js Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170278|0 |1 is obsolete| | --- Comment #73 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 180564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180564&action=edit Bug 27428: (follow-up) show the number instead [[object Object]], move OPACDisplayRecordCount to the 'Features' section Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170279|0 |1 is obsolete| | --- Comment #74 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 180565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180565&action=edit Bug 27428: (follow-up) Update system preference description Add Elasticsearch only to OPACDisplayRecordCount description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #75 from Hammat wele <hammat.wele@inlibro.com> --- I've rebased this after applying 27113 since it depends on 27113. Now this patch should apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #76 from David Nind <david@davidnind.com> --- I get a sha1/fake ancestor error when applying this patch. Note that bug 27113 is failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #77 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to David Nind from comment #76)
I get a sha1/fake ancestor error when applying this patch.
Note that bug 27113 is failed QA.
Hello David, Thanks for your feedback. On my side, the patch applies cleanly without any sha1/fake ancestor errors. I only applied the patch for bug 27113, and did not apply the patch for bug 25870, which might explain the difference. Bug 27428 Depends on bug 25870 (Failed QA) Follow? [(y)es, (n)o] n Bug 27428 Depends on bug 27113 (Needs Signoff) Follow? [(y)es, (n)o] y Bug 27113 Depends on bug 25870 (Failed QA) Follow? [(y)es, (n)o] n -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED Summary|Show the number of records |Show the number of records |in the bibliographic record |in the bibliographic record |detail page with |detail page with |ElasticSearch |Elasticsearch --- Comment #78 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Setting to BLOCKED as one of the dependencies (bug 25870) is currently 'Failed QA'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180561|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180565|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #79 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 196519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196519&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #80 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 196520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196520&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #81 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 196521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196521&action=edit Bug 27428: (follow-up) perltidy, change the atomic file to the newer format, moving system preference to Features section and Fixing opac-display-record-count.js Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #82 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 196522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196522&action=edit Bug 27428: (follow-up) show the number instead [[object Object]], move OPACDisplayRecordCount to the 'Features' section Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #83 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 196523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196523&action=edit Bug 27428: (follow-up) Update system preference description Add Elasticsearch only to OPACDisplayRecordCount description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 --- Comment #84 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 199914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199914&action=edit Bug 27428: (follow-up) Use URLSearchParams to get q parameter Patch from commit 999c4de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355 [Bug 43355] Add a /search API endpoint for biblios -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org