https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #49 from David Cook <dcook@prosentient.com.au> --- Is this a brand new development or is this something inLibro has had around for a while? I haven't read through everything here, but noticing some issues. While we don't explicitly have a coding guideline for this, we shouldn't be adding new "svc" scripts. API calls should be added via the REST API. I see that "opac/svc/elasticsearch/opac-elasticsearch.pl" doesn't have any authentication or authorization (even if it's a public endpoint, this is needed for appropriate session handling at the very least), and has completely non-standard output. It's also not clear to me why you're using Unicode::Normalize here. The "not_symbols" bit in "koha-tmpl/opac-tmpl/bootstrap/js/opac-display-record-count.js" is also weird. I could be missing something but I have a feeling that something isn't right here. -- You are receiving this mail because: You are watching all bug changes.