[Bug 40690] New: Checkout status doesn't appear on moredetail.pl if item has never been checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Bug ID: 40690 Summary: Checkout status doesn't appear on moredetail.pl if item has never been checked out Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com If you go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD, you'll see that there is a blank next to "Checkout status:". This might not seem weird at first, until you notice that moredetail.tt actually has some HTML that you think would apply in this scenario: <span>Not checked out</span> If you look at the template, you quickly see there's clearly a bug there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checkout status doesn't |Checkout status doesn't |appear on moredetail.pl if |appear on moredetail.pl if |item has never been checked |item is not checked out |out | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 185705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185705&action=edit Bug 40690: Fix if/else/end logic for checkout This change fixes the Checkout status on moredetail.pl so that it actually shows "Not checked out" when it's not checked out. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD 2. Note that the "Checkout status" is "Not checked out" 3. Check out the item to someone 4. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 5. Note that it says "Checked out to <person> Due back on <date>" 6. Renew the item 7. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 8. Note that it says "Checked out to <person> Last renewed <date>, Due back on <date>" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185705|0 |1 is obsolete| | --- Comment #2 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 185727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185727&action=edit Bug 40690: Fix if/else/end logic for checkout This change fixes the Checkout status on moredetail.pl so that it actually shows "Not checked out" when it's not checked out. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD 2. Note that the "Checkout status" is "Not checked out" 3. Check out the item to someone 4. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 5. Note that it says "Checked out to <person> Due back on <date>" 6. Renew the item 7. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 8. Note that it says "Checked out to <person> Last renewed <date>, Due back on <date>" Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |anneli.osterman@koha-suomi. | |fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [% IF ( checkout.date_due ) %] <span>Due back on [% checkout.date_due | $KohaDates as_due_date => 1 %]</span> [% END %] Makes me wonder if you could checkout without a due date ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185727|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 185873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185873&action=edit Bug 40690: Fix if/else/end logic for checkout This change fixes the Checkout status on moredetail.pl so that it actually shows "Not checked out" when it's not checked out. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 on a fresh KTD 2. Note that the "Checkout status" is "Not checked out" 3. Check out the item to someone 4. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 5. Note that it says "Checked out to <person> Due back on <date>" 6. Renew the item 7. Go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=29 8. Note that it says "Checked out to <person> Last renewed <date>, Due back on <date>" Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40690 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org