[Bug 29552] New: flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Bug ID: 29552 Summary: flatpickr misses quick shortcut to "Today" date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: rel_22_05_candidate Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: david@davidnind.com, jonathan.druart+koha@gmail.com, martin.renvoize@ptfs-europe.com, nugged@gmail.com, testopia@bugs.koha-community.org Depends on: 29478
From bug 29478 comment 5:
I thought of an issue when testing my follow-up: Should the shortcut controls reflect the date limitations of the flatpickr instance? For instance, if selection is limited to a date before today, should the "today" and "tomorrow" controls be disabled? Currently clicking a shortcut for a date which is disallowed will empty the date field.
I decided we should go with what we have for this coming release, but we should really implement the above asap after release. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 [Bug 29478] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|flatpickr misses quick |flatpickr quick shortcuts |shortcut to "Today" date |should be 'Disabled' for | |invalid dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds shortcuts to | release notes|yesterday, today and | |tomorrow for the flatpickr | |date selector. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127954&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I was curious to know how easy/hard it would be to implement so I gave it a try. It seems quite easy actually, here is my version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127954|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 128221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128221&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 128222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128222&action=edit Bug 29552: (follow-up) Use CSS to set disabled class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #5 from David Nind <david@davidnind.com> --- I had a go at testing but came across some issues (or I don't understand how to test this...). Testing notes using koha-testing-docker: 1. Update the CSS (yarn install, yarn build, yarn build --view opac, flush_memcached, restart_all) 2. Examples of where yesterday, today and tomorrow should not be active: . Place a hold for: for 'Hold expires on date:' yesterday and today should not be active [see potential issue [1]] . Circulation > Overdue report: in the filter make the from date in the future, Yesterday, Today and Tomorrow should all be not active, but are active even though they don't work . Struggled to find examples of when Tomorrow should not be selectable Potential issues noted - mainly with Yesterday, Today and Tomorrow not showing as inactive when they should be: 1. When placing a hold you can't enter today's date but 'Today' is still active 2. Same for Circulation > Renew 3. Administration > Patron categories > New category - Yesterday and Today are still active, even though you can't enter a date 4. Reports > Patrons: the "Date of birth" fields are linked so that to cannot be before from dates, if you add a date in the from taht is a few days in the future tehy should all be inactive, but aren't -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128221|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128510&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128222|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128511&action=edit Bug 29552: (follow-up) Use CSS to set disabled class Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128512&action=edit Bug 29552: (follow-up) Reverse SCSS declaration order I'm not sure why, but the order matters in this SCSS declaration. If the &:hover is placed below the &:disabled, as it was, then it appears to negate the effect of the &:disabled rule entirely. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works well once I applied my follow-up. Test plan I followed: 1. Update CSS (This is a staff client patch.. so yarn build [no --view=opac]) 2. Follow Davids test plan, but for staff client pages only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I still see some glitches here: 1) Place a hold in staff and set the expiration date - Yesterday is inactive - OK - Today doesn't jump to today when clicked, but is still active (not OK) 2) Set a date of birth for a patron - You can set a date of birth into the future. All options are active an and work. (possibly not related to this patch?) 3) Administration > Edit or add a patron category > Set the "Until date" - Dates in the past are greyed out, Yesterday and Today are active, but won't select a date (not OK) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128729&action=edit Bug 29552: Disable today for dates in the future -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29735 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #10)
I still see some glitches here:
1) Place a hold in staff and set the expiration date - Yesterday is inactive - OK - Today doesn't jump to today when clicked, but is still active (not OK)
Done
2) Set a date of birth for a patron - You can set a date of birth into the future. All options are active an and work. (possibly not related to this patch?)
That does not seem directly related.
3) Administration > Edit or add a patron category > Set the "Until date" - Dates in the past are greyed out, Yesterday and Today are active, but won't select a date (not OK)
Opened bug 29735. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #9)
This works well once I applied my follow-up.
Test plan I followed: 1. Update CSS (This is a staff client patch.. so yarn build [no --view=opac]) 2. Follow Davids test plan, but for staff client pages only.
It's working without your patch but the cache is hard to clear (?) I had to open a private window to make it work (so with Owen's patch only, not yours). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128512|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128510|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128806&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128511|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128807&action=edit Bug 29552: (follow-up) Use CSS to set disabled class Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128729|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128808&action=edit Bug 29552: Disable today for dates in the future -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested on top of bug 29735. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128806|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128809&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128807|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128810&action=edit Bug 29552: (follow-up) Use CSS to set disabled class Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128808|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128811&action=edit Bug 29552: Disable today for dates in the future Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle@bywatersolutions.com --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org