[Bug 24736] New: "Enrollments" not correctly disabled when nobody is enrolled to a club yet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 Bug ID: 24736 Summary: "Enrollments" not correctly disabled when nobody is enrolled to a club yet Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The link is disabled but it's possible to click and access the page anyway. https://snipboard.io/eqHYBu.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99664&action=edit Bug 24736: Disable "Enrollments" link if nobody enrolled to the club yet The link is disabled but it's possible to click and access the page anyway. Test plan: - Create a new club template - Create a new club - Click the Actions > Enrollments link => Without this patch you can access the page => With this patch applied you cannot, and a tooltip explains why (feel free to suggest another wording) - Add a new patron to this club (from /cgi-bin/koha/opac-user.pl#opac-user-clubs) - Notice that the action link is not enabled and click takes you to the list of enrollments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99664|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 99672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99672&action=edit Bug 24736: Disable "Enrollments" link if nobody enrolled to the club yet The link is disabled but it's possible to click and access the page anyway. Test plan: - Create a new club template - Create a new club - Click the Actions > Enrollments link => Without this patch you can access the page => With this patch applied you cannot, and a tooltip explains why (feel free to suggest another wording) - Add a new patron to this club (from /cgi-bin/koha/opac-user.pl#opac-user-clubs) - Notice that the Enrollment action link in the staff interface is now enabled and clicking on it takes you to the list of enrollments Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99672|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99809&action=edit Bug 24736: Disable "Enrollments" link if nobody enrolled to the club yet The link is disabled but it's possible to click and access the page anyway. Test plan: - Create a new club template - Create a new club - Click the Actions > Enrollments link => Without this patch you can access the page => With this patch applied you cannot, and a tooltip explains why (feel free to suggest another wording) - Add a new patron to this club (from /cgi-bin/koha/opac-user.pl#opac-user-clubs) - Notice that the action link is not enabled and click takes you to the list of enrollments Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99810&action=edit Bzg 24736: (QA follow-up) Change tooltip wording Suggesting a change of the tooltip wording to read: There are no enrollments for this club yet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24736 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org