[Bug 33526] New: Use template wrapper for tabs: Bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Bug ID: 33526 Summary: Use template wrapper for tabs: Bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the bibliographic detail page in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 [Bug 33195] Reindent the bibliographic details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151489&action=edit Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Bug 33526 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167352&action=edit Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - The components tab should be automatically selected - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - The media tab should be selected by default - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs Sponsored-By: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167352|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167360&action=edit Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - The components tab should be automatically selected - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - The media tab should be selected by default - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 [Bug 2486] Show user comments in staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167360|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168726&action=edit Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - The components tab should be automatically selected - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - The media tab should be selected by default - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another nice improvement, thanks Owen. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use template wrapper for |Use template wrapper for |tabs: Bibliographic detail |tabs: bibliographic detail |page |page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 [Bug 37330] LocalCoverImages for items don't show if StaffDetailItemSelection disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Bug 33526 depends on bug 33195, which changed state. Bug 33195 Summary: Reindent the bibliographic details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Skipping release notes for being a more technical change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #8 from David Nind <david@davidnind.com> --- A technical change, no changes to the manual required. If there are any screenshot changes (my reading of the bug says there shouldn't be), these will hopefully be picked up by the automated screenshot capture. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Bug 33526 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org