[Bug 30632] New: Fix report author display in list of saved reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Bug ID: 30632 Summary: Fix report author display in list of saved reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Blocks: 30617 The author of a report shows as: Fischer , Katrin (51) The additional space before comma should be removed. I assume it should be switched over to using one of the standardized ways to show patron names, see bug 30617 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 [Bug 30617] [OMNIBUS] We should consistently use includes for patron name display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |30491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491 [Bug 30491] Convert saved reports tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134281&action=edit Bug 30632: Fix report author display in list of saved reports This patch removes whitespace in the template around the markup of report author first name and surname. This prevents unwanted spaces in the output. To test, apply the patch and go to Reports -> Use saved. The display of report author should be like this: Leonard, Owen (123456) Instead of Leonard , Owen (20375) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With all the patches for preferred name/middle name and such I was wondering if we could use patron-title.inc here. Is there a reason not to? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I made this quick template fix because fixing it to use the patron-title include would require more complex updates to the way reports are queried. I certainly do not object if someone wants to take that route instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134281|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 134303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134303&action=edit Bug 30632: Fix report author display in list of saved reports This patch removes whitespace in the template around the markup of report author first name and surname. This prevents unwanted spaces in the output. To test, apply the patch and go to Reports -> Use saved. The display of report author should be like this: Leonard, Owen (123456) Instead of Leonard , Owen (20375) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |report authors in the list | |of saved reports to remove | |the extra space before the | |comma (Lastname, Firstname | |was displaying as Lastname | |, Firstname). CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134303|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134355&action=edit Bug 30632: Fix report author display in list of saved reports This patch removes whitespace in the template around the markup of report author first name and surname. This prevents unwanted spaces in the output. To test, apply the patch and go to Reports -> Use saved. The display of report author should be like this: Leonard, Owen (123456) Instead of Leonard , Owen (20375) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30491 | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am ok with the simple fix. I am filing a new one to "switch" to the include. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491 [Bug 30491] Convert saved reports tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491 [Bug 30491] Convert saved reports tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30651 [Bug 30651] Switch report author in saved SQL reports list to include -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Blocks|30617 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 [Bug 30617] [OMNIBUS] We should consistently use includes for patron name display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Bug 30632 depends on bug 30491, which changed state. Bug 30491 Summary: Convert saved reports tabs to Bootstrap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30491 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30632 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org