[Bug 13548] New: "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548 Bug ID: 13548 Summary: "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Partner wants to decrease the length of loans when *any* items are checked out. Setting 'decreaseLoahHighHolds' system preferences as follows: +-------------------------------+------------+ | variable | value | +-------------------------------+------------+ | decreaseLoanHighHolds | 1 [Enable] | | decreaseLoanHighHoldsDuration | 14 | | decreaseLoanHighHoldsValue | 0 | +-------------------------------+------------+ This shows on the system preferences screen as follows: [Enable] the reduction of loan period to [14] days for items with more than [0] holds. Checking out *any* item (regardless of whether or not it has holds) will trigger the following message: High demand item. Loan period shortened to 0 days (due ). Check out anyway? According to the system preferences description, this should not be triggered unless there is at least one hold. According to the partner, if decreaseLoanHighHoldsValue is set to 1, High Holds isn't triggered until an item is checked out that has two holds placed, meaning that it's impossible to trigger at exactly 1 hold placed. when decreaseLoanHighHoldsValue is 0, the loan period is *not* shortened, even though the message pops up. The description of decreaseLoanHighHoldsDuration is also misleading: [Enable] the reduction of loan period to [decreaseLoanHighHoldsDuration] days should read [Enable] the reduction of loan period by [decreaseLoanHighHoldsDuration] days because, the loan period is not set to a constant 'decreaseLoanHighHoldsDuration' days; rather it is decremented by that amount. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |eivin@sysmystic.com |ity.org | CC| |eivin@sysmystic.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548 --- Comment #1 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42442&action=edit Bug 13548: "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. This solves the problem since there was a boolean check that evaluated to false because of the 0. To test: 1. Apply patch. 2. Enable decreaseLoanHighHolds and set decreaseLoanHighHoldsValue to 0. 3. Check out an item without holds and see that the behaviour is now correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org