[Bug 16560] New: Translatability: Issues in opac-memberentry.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Bug ID: 16560 Summary: Translatability: Issues in opac-memberentry.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In opac-memberentry.tt, the following parts lead to translaiton errors because of sentence splitting by tags: <strong>The entered <a href="#borrower_cardnumber">card number</a> is the wrong length.</strong> <strong>The entered <a href="#borrower_cardnumber">card number</a> is already in use.</strong> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 51718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51718&action=edit Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt This patch fixes two splitted sentences to avoid translation issues: The entered <a href="#borrower_cardnumber">card number</a> is the wrong length. The entered <a href="#borrower_cardnumber">card number</a> is already in use. To test: Apply patch and verify that html in the 2 that are changed is correct and that they are not splitted by a-tags. Note: I could not figure out under which conditions this code displays in the OPAC self registration form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51718|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 51896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51896&action=edit Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt This patch fixes two splitted sentences to avoid translation issues: The entered <a href="#borrower_cardnumber">card number</a> is the wrong length. The entered <a href="#borrower_cardnumber">card number</a> is already in use. To test: Apply patch and verify that html in the 2 that are changed is correct and that they are not splitted by a-tags. Note: I could not figure out under which conditions this code displays in the OPAC self registration form. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51896|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52245&action=edit Bug 16560: Translatability: Issues with "The entered " in opac-memberentry.tt This patch fixes two splitted sentences to avoid translation issues: The entered <a href="#borrower_cardnumber">card number</a> is the wrong length. The entered <a href="#borrower_cardnumber">card number</a> is already in use. To test: Apply patch and verify that html in the 2 that are changed is correct and that they are not splitted by a-tags. Note: I could not figure out under which conditions this code displays in the OPAC self registration form. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16560 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14659 Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org