[Bug 28139] New: Processing holds are not filled automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Bug ID: 28139 Summary: Processing holds are not filled automatically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: joonas.kylmala@helsinki.fi Reporter: joonas.kylmala@helsinki.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 25690, 28136 If you check in Processing hold and have HoldsAutoFill pref enabled the hold is not filled automatically as they should be according to the HoldsAutoFill syspref. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 [Bug 28136] Transferred holds are not triggering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 119511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119511&action=edit Bug 28139: Handle Processing status with HoldsAutoFill pref turned on To test: 1: Turn on HoldsAutoFill setting 2: Place a item-level hold on item X at Branch A 3: Make the hold to Processing state: $ koha-mysql kohadev
select * from reserves; # look up the reserve_id UPDATE reserves SET found = 'P', priority = 0 WHERE reserve_id = XXX; 4: Check in the item X at Branch A - A pop-up asking confirmation comes 5: Apply patch & restart plack 6: Check in the item X again at Branch A - now the hold is confirmed automatically
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 119512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119512&action=edit Bug 28139: Simplify logic for handling found holds in returns.pl We are handling in this if-else block 3 cases: - Hold found and waiting - Hold found but not waiting AND whether HoldsAutoFill is enabled - Hold found but not waiting AND whether HoldsAutoFill disabled If we simply first handle hold found = Waiting case first then we don't have to individually list all those other found cases and that simplifies this code a lot. To test: 1. Apply patch 2. Make sure HoldsAutoFill is disabled 3. Make item-level hold on branch A 4. Check-in the item at branch A and you should get pop-up confirming the hold, ignore it 5. Set HoldsAutoFill is enabled 4. Check-in the item again and you now the hold should have been automatically filled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate CC| |fridolin.somers@biblibre.co | |m, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119511|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119586&action=edit Bug 28139: Handle Processing status with HoldsAutoFill pref turned on To test: 1: Turn on HoldsAutoFill setting 2: Place a item-level hold on item X at Branch A 3: Make the hold to Processing state: $ koha-mysql kohadev
select * from reserves; # look up the reserve_id UPDATE reserves SET found = 'P', priority = 0 WHERE reserve_id = XXX; 4: Check in the item X at Branch A - A pop-up asking confirmation comes 5: Apply patch & restart plack 6: Check in the item X again at Branch A - now the hold is confirmed automatically
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119512|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119587&action=edit Bug 28139: Simplify logic for handling found holds in returns.pl We are handling in this if-else block 3 cases: - Hold found and waiting - Hold found but not waiting AND whether HoldsAutoFill is enabled - Hold found but not waiting AND whether HoldsAutoFill disabled If we simply first handle hold found = Waiting case first then we don't have to individually list all those other found cases and that simplifies this code a lot. To test: 1. Apply patch 2. Make sure HoldsAutoFill is disabled 3. Make item-level hold on branch A 4. Check-in the item at branch A and you should get pop-up confirming the hold, ignore it 5. Set HoldsAutoFill is enabled 4. Check-in the item again and you now the hold should have been automatically filled Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work, this makes the code a fair bit clearer and fixes the Processing status as the test plan describes. Signing off, thanks Joonas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119586|0 |1 is obsolete| | Attachment #119587|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119590&action=edit Bug 28139: Handle Processing status with HoldsAutoFill pref turned on To test: 1: Turn on HoldsAutoFill setting 2: Place a item-level hold on item X at Branch A 3: Make the hold to Processing state: $ koha-mysql kohadev
select * from reserves; # look up the reserve_id UPDATE reserves SET found = 'P', priority = 0 WHERE reserve_id = XXX; 4: Check in the item X at Branch A - A pop-up asking confirmation comes 5: Apply patch & restart plack 6: Check in the item X again at Branch A - now the hold is confirmed automatically
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119591&action=edit Bug 28139: Simplify logic for handling found holds in returns.pl We are handling in this if-else block 3 cases: - Hold found and waiting - Hold found but not waiting AND whether HoldsAutoFill is enabled - Hold found but not waiting AND whether HoldsAutoFill disabled If we simply first handle hold found = Waiting case first then we don't have to individually list all those other found cases and that simplifies this code a lot. To test: 1. Apply patch 2. Make sure HoldsAutoFill is disabled 3. Make item-level hold on branch A 4. Check-in the item at branch A and you should get pop-up confirming the hold, ignore it 5. Set HoldsAutoFill is enabled 4. Check-in the item again and you now the hold should have been automatically filled Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Bug 28139 depends on bug 28136, which changed state. Bug 28136 Summary: Transferred holds are not triggering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org