https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95862&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95864&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95862|0 |1 is obsolete| | --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95866&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95864|0 |1 is obsolete| | --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 95868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95868&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This needs to be rebuilt on top of bug 18936. And even bug 15522 I'd say. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95866|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 98750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98750&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95868|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 98752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98752&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98749|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 98765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98765&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals - An update for the renewals letter to include a message for unseen renewals -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98751|0 |1 is obsolete| | --- Comment #17 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 98767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98767&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #19 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- - Apply patches (if on a platform requiring this to be done manually) - Run DB updates and rebuild schema (if on a platform requiring this to be done manually) - Rebuild CSS (if on a platform requiring this to be done manually) - Issue an item to a patron - Navigate to Koha Administration > Circulation and fines rules => TEST: Observe that there *isn't* a column titled "Unseen renewals allowed (count)" - Navigate to a patron's checkouts list => TEST: Observe that in the "Renew" column, only details of their remaining renewals are shown, unseen renewals are not mentioned - Turn on the "OpacRenewalAllowed" syspref - Navigate to a patron's "Your account" page => TEST: Observe that in the "Renew" column, only details of their remaining renewals are shown, unseen renewals are not mentioned - Turn on the "UnseenRenewals" syspref - Navigate to Koha Administration > Circulation and fines rules - If you have no circulation rules defined, define one that will: - Apply to all patron categories - Apply to item types - Allow renewals => TEST: Observe that there *is* a column titled "Unseen renewals allowed (count)" and the value is empty - Add a value for "Unseen renewals allowed", make the value reasonably low so we can test what happens when that value is reached - Navigate to a patron's checkouts list in the staff client => TEST: Observe that in the "Renew" column, details of their remaining unseen renewals are now shown - Navigate to a patron's "Your account" page => TEST: Observe that in the "Renew" column, details of their remaining unseen renewals are now shown - In the OPAC, renew an item => TEST: Observe that, since the renewal took place in the OPAC, the number of unseen renewals left is decremented - In the OPAC, repeatedly renew the item until the unseen renewals limit is reached => TEST: Observe that the item can no longer be renewed and the borrower is advised to take the item to the library - Navigate to the patron's checkouts list in the staff client => TEST: Observe that the item is listed as "Must be renewed at the library" and is blocked from renewal - Select the "Override renewal restrictions" checkbox => TEST: Observe that the item can now be selected for renewal - Select the item and click "Renew or check in selected items" => TEST: Observe that now the item has been renewed by the library, the unseen renewals remaining count has been reset - Select the item for renewal again and check the "Renew as unseen if appropriate" checkbox, click "Renew or check in selected items" => TEST: Observe that, since the item was renewed as "unseen", the unseen renewals remaining has been decremented - Navigate to Circulation > Renew => TEST: Observe that a new "Record renewal as unseen if appropriate" checkbox is displayed - Renew the item, do not check the unseen checkbox => TEST: Observe in the patron's checkouts list that the unseen renewals count has not been decremented - Renew the item, check the unseen checkbox => TEST: Observe in the patron's checkouts list that the unseen renewals count has been decremented - Navigate to Tools > Notices & Slips, edit the "AUTO_RENEWALS" Email notice => TEST: Observe that there is now a test for the "too_unseen" error, with an appropriate message SIP RENEWALS: - Use sip_cli_emulator.pl to send a renew message for the item, for example: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su <kiosk_username> -sp <kiosk_password> --patron <patron_username> --password <patron_password> -l CPL -i <item_barcode> -m renew - TEST: Observe that, as the SIP renewal is considered to be "seen", the item's unseen renewals count has been reset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98765|0 |1 is obsolete| | --- Comment #20 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 100244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100244&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals - An update for the renewals letter to include a message for unseen renewals -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98767|0 |1 is obsolete| | --- Comment #22 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 100246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100246&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100245|0 |1 is obsolete| | --- Comment #25 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 100381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100381&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100247|0 |1 is obsolete| | --- Comment #27 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 100383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100383&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100381|0 |1 is obsolete| | --- Comment #32 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 110608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110608&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100383|0 |1 is obsolete| | --- Comment #34 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 110610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110610&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #36 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- - Apply patches (if on a platform requiring this to be done manually) - Run DB updates and rebuild schema (if on a platform requiring this to be done manually) - Rebuild CSS (if on a platform requiring this to be done manually) - Issue an item to a patron - Navigate to Koha Administration > Circulation and fines rules => TEST: Observe that there *isn't* a column titled "Unseen renewals allowed (count)" - Navigate to a patron's checkouts list => TEST: Observe that in the "Renew" column, only details of their remaining renewals are shown, unseen renewals are not mentioned - Navigate to a patron's "Your account" page => TEST: Observe that in the "Renew" column, only details of their remaining renewals are shown, unseen renewals are not mentioned - Turn on the "UnseenRenewals" syspref - Turn on the "OpacRenewalAllowed" syspref - Navigate to Koha Administration > Circulation and fines rules - If you have no circulation rules defined, define one that will: - Apply to all patron categories - Apply to item types - Allow renewals => TEST: Observe that there *is* a column titled "Unseen renewals allowed (count)" and the value is empty - Add a value for "Unseen renewals allowed", make the value reasonably low so we can test what happens when that value is reached - Navigate to a patron's checkouts list in the staff client => TEST: Observe that in the "Renew" column, details of their remaining unseen renewals are now shown - Navigate to a patron's "Your account" page => TEST: Observe that in the "Renew" column, details of their remaining unseen renewals are now shown - In the OPAC, renew an item => TEST: Observe that, since the renewal took place in the OPAC, the number of unseen renewals left is decremented - In the OPAC, repeatedly renew the item until the unseen renewals limit is reached => TEST: Observe that the item can no longer be renewed and the borrower is advised to take the item to the library - Navigate to the patron's checkouts list in the staff client => TEST: Observe that the item is listed as "Must be renewed at the library" and is blocked from renewal - Select the "Override renewal restrictions" checkbox => TEST: Observe that the item can now be selected for renewal - Select the item and click "Renew or check in selected items" => TEST: Observe that now the item has been renewed by the library, the unseen renewals remaining count has been reset - Select the item for renewal again and check the "Renew as unseen if appropriate" checkbox, click "Renew or check in selected items" => TEST: Observe that, since the item was renewed as "unseen", the unseen renewals remaining has been decremented - Navigate to Circulation > Renew => TEST: Observe that a new "Record renewal as unseen if appropriate" checkbox is displayed - Renew the item, do not check the unseen checkbox => TEST: Observe in the patron's checkouts list that the unseen renewals count has been reset - Renew the item, check the unseen checkbox => TEST: Observe in the patron's checkouts list that the unseen renewals count has been decremented - Navigate to Tools > Notices & Slips, edit the "AUTO_RENEWALS" Email notice => TEST: Observe that there is now a test for the "too_unseen" error, with an appropriate message SIP RENEWALS: - Use sip_cli_emulator.pl to send a renew message for the item, for example: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su <kiosk_username> -sp <kiosk_password> --patron <patron_username> --password <patron_password> -l CPL -i <item_barcode> -m renew - TEST: Observe that, as the SIP renewal is considered to be "seen", the item's unseen renewals count has been reset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, starting with some QA work here. Tbh I've never heard of this specific functionality in an ILS before and am a bit stumped on the use case. Can you explain a bit on how this is used in libraries? 1) QA script fails FAIL C4/Circulation.pm OK critic FAIL forbidden patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 2933) FAIL t/db_dependent/Circulation/issue.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Can't locate Koha/IssuingRules.pm in @INC (you may need to install the Koha::IssuingRules module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/kohadev/plugins) 2) Database updates There is lots of them :) a) The one thing that gives me a bit of a headache is the change to the notices for existing installations. I think we should leave that one out as we cannot safely assume what people have 'done' to this notice - they will have translated it, might have decided to not inform patrons of the reasons at all, changed the structure etc. I feel we should not interfere here. b) You have a mismatch between kohastructure.sql and the updates for issues/old_issues: AFTER renewals vs. after auto_renew 3) Strings in Javascript This is an old patch, I am aware, but not sure if you have seen yet: We are moving the strings back into the js as they can be finally translated within the file now. See bug 21156 for examples. I am not going to block this, but it would be nice if the patches could be changed to use the new mechanism right away. 4) Terminology We just did a major clean-up on the system preferences, that's why I am a bit nit-picky there. Every change later requires translators to do the work again too - so it might be forgiven: + - renewals to be recorded as "unseen" by the library, and count against the borrowers unseen renewals limit Can you please make the borrowers patrons and add a .? 5) Web based self check Renewals are also possible with the web based self check - so I feel some changes will be needed there as well! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110608|0 |1 is obsolete| | --- Comment #40 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111148&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110610|0 |1 is obsolete| | --- Comment #42 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111150&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #44 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111152&action=edit Bug 24083: (follow-up) Respond to QA feedback This patch implements changes requested by Katrin in QA feedback (comment #38): - Fix QA script failures - Remove notice text database update - Fix alter table column order mismatch - Use new convention for JS strings - Fix terminology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

...

5) Web based self check

I'm not sure what you mean here. Do you mean the renewal function in the "My account" in the OPAC? If so, unseen renewals are already handled there. I'm guessing you're referring to something else though...

Hi Andrew, thx for the follow-ups, what I meant is the web based self check module, see SelfCheckInModule and WebBasedSelfCheck - the latter also has the option to make renewals either by scanning in an item agan (seen?) and by renewing them directly (unseen). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111148|0 |1 is obsolete| | --- Comment #48 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111284&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111150|0 |1 is obsolete| | --- Comment #50 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111286&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111152|0 |1 is obsolete| | --- Comment #52 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111288&action=edit Bug 24083: (follow-up) Respond to QA feedback This patch implements changes requested by Katrin in QA feedback (comment #38): - Fix QA script failures - Remove notice text database update - Fix alter table column order mismatch - Use new convention for JS strings - Fix terminology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #54 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111290&action=edit Bug 24083: (follow-up) Fix error in checkouts JS This commit fixes a small error in the checkouts related JS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #56 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111292&action=edit Bug 24083: (follow-up) Fix unit tests Some changes in issue.t had broken the tests for unseen renewals (the unseen tests were using variables that had been moved out of the tests' scope). Also now using Koha::CirculationRules::set_rules to set circ rules rather than using SQL queries. Fixed expected number of return values from GetRenewCount Moved unseen tests in issue.t to the bottom of the file to remove the risk of interference with other test circ rules. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #58 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #46)

Hi Andrew,

thx for the follow-ups, what I meant is the web based self check module, see SelfCheckInModule and WebBasedSelfCheck - the latter also has the option to make renewals either by scanning in an item agan (seen?) and by renewing them directly (unseen).

Hi Katrin Thanks for the clarification, I didn't even know this area of Koha existed! Anyway, I have now added awareness of seen vs unseen to it so should prevent renewals when appropriate with a suitable error message. I've also fixed some unit tests that were broken as a result of changes since this was last rebased. I've also fixed a major rebase error that crept in in February, to be honest it's amazing anything worked at all with it in, anyway it's fixed now. Setting this back to "Signed off" with crossed fingers... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111283|0 |1 is obsolete| | --- Comment #60 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111849&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals - An update for the renewals letter to include a message for unseen renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111285|0 |1 is obsolete| | --- Comment #62 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111851&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111287|0 |1 is obsolete| | --- Comment #64 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111853&action=edit Bug 24083: (follow-up) Fix params to AddRenewal The merging of Bug 23051 has added a paramter that can be passed to C4::AddRenewal. This bug does also, so the offset of this bug's new paramter was wrong. This patch fixes it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111289|0 |1 is obsolete| | --- Comment #66 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111855&action=edit Bug 24083: (follow-up) Include SelfCheckInModule As highlighted by Katrin, the selfcheckin module was not aware of this work. This commits gives it awareness of the too_unseen renew error and the "seen" argument that can be passed to AddRenewal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111291|0 |1 is obsolete| | --- Comment #68 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111857&action=edit Bug 24083: (follow-up) Fix GetRenewCount return GetRenewCount now returns 6 values when a call to it succeeds, a failed call should also return the same number of values. This commit adds these additional values. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111293|0 |1 is obsolete| | --- Comment #70 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111859&action=edit Bug 24083: (follow-up) Fix bad rebase There was a real mess in C4/Circulation.pm due to a bad rebase back in February. Frankly it's a wonder anything worked at all. This commit fixes that problem and reinstates the correct patch for C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #72 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Sorry Katrin, another bad rebase. All these rebases are a nightmare for introducing errors. Anyway, hopefully it will now be good. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Done lots of successful testing, but getting stuck a bit at the mechanics of this: 1) I turned on the unseen/seen renewals feature. My total allowed renewals are 5. Unseen 4. My checked out item in the OPAC now shows: Renew ( 2 of 5 renewals remaining / 4 of 4 renewals left before the item must be seen by the library ) In this case it's extra confusing because I have done renewals before the feature was activated. Then I have renewed the item by checking it out again. It now reads: Renew ( 1 of 5 renewals remaining / 4 of 4 renewals left before the item must be seen by the library ) So it appears to have reset the renewals. But: If I renew the item in the OPAC now, I get: Renewed! Not renewable I feel like it's confusing to patrons that it says I have x renewals left, but this number is smaller than the unseen renewals available. It would make sense if the "seen" renewal reset the counter, but that doesn't appear to happen. 2) Checked my item in again and back out to reset all counters. OPAC reads: Renew ( 5 of 5 renewals remaining / 4 of 4 renewals left before the item must be seen by the library ) Renew once in the OPAC. Renew ( 4 of 5 renewals remaining / 3 of 4 renewals left before the item must be seen by the library ) Renew using the renew tab in staff client: ( 3 of 5 renewals remaining / 4 of 4 renewals left before the item must be seen by the library ) So this appears to have reset the "unseen" renewals, which I think is correct. My issue here is that I think it will be very confusing to the patrons, do they have 3 or 4 renewals left now? (actually only 3, otherwise the item has to be checked in and out again and everything will be reset. Maybe we should just show the patrons how many more online renewals are possible before they have to take the item to the library for renewal? OR: ( 3 of 5 renewals remaining / 4 of 4 renewals left before the item must be seen by the library ) Would change to the following, when the unseen renewals are higher than the actual remaining ones: ( 3 of 5 renewals remaining ) AND: ( 4 of 5 renewals remaining / 2 of 2 renewals left before the item must be seen by the library ) Could be: ( 2 online renewals remaining before the item must be seen by the library ) I guess besides the confusing display I wonder if the count of renewals should be reset by a seen renewal? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 4) Please add the new test for too_unseen to the AUTO_RENEW default notices, so that new installations will have it and we have a default notice to refer to. Addition to 1) and 2), trying to be clearer about the issue: In my last test case I see: Renew ( 4 of 5 renewals remaining / 1 of 2 renewals left before the item must be seen by the library ) This does kind of make sense to me now. I still think it might be clearer to leave out the unseen renewals if they no longer apply, because all remaining renewals can be done online. (2 of 5, 2 of 2 => 2 of 5) I think 3) and 4) should be fixed. 1) and 2) might be good to put some more thought into separately, not blocker for me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111849|0 |1 is obsolete| | --- Comment #78 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 112230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112230&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals - An update for the renewals letter to include a message for unseen renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111851|0 |1 is obsolete| | --- Comment #80 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 112232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112232&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111853|0 |1 is obsolete| | --- Comment #82 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 112234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112234&action=edit Bug 24083: (follow-up) Fix params to AddRenewal The merging of Bug 23051 has added a paramter that can be passed to C4::AddRenewal. This bug does also, so the offset of this bug's new paramter was wrong. This patch fixes it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111855|0 |1 is obsolete| | --- Comment #84 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 112236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112236&action=edit Bug 24083: (follow-up) Include SelfCheckInModule As highlighted by Katrin, the selfcheckin module was not aware of this work. This commits gives it awareness of the too_unseen renew error and the "seen" argument that can be passed to AddRenewal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111857|0 |1 is obsolete| | --- Comment #86 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 112238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112238&action=edit Bug 24083: (follow-up) Fix GetRenewCount return GetRenewCount now returns 6 values when a call to it succeeds, a failed call should also return the same number of values. This commit adds these additional values. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111859|0 |1 is obsolete| | Attachment #111860|0 |1 is obsolete| | --- Comment #88 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 112240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112240&action=edit Bug 24083: (follow-up) Fix bad rebase There was a real mess in C4/Circulation.pm due to a bad rebase back in February. Frankly it's a wonder anything worked at all. This commit fixes that problem and reinstates the correct patch for C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #90 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 112242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112242&action=edit Bug 24083: (follow-up) Fix misaligned columns Somehow I'd never noticed this before but the columns in smart-rules.tt were misaligned when UnseenRenewals was turned off. This was due to the display of a <td> not being conditional when it should have been. This is now fixed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #92 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin I've just fixed 1 & 2. 1 was due to a mistake during a rebase back in early October. For 2, I didn't modify the de-DE notice as you previously requested. As far as 3 & 4 are concerned, I'd be super keen for those to be enhancements after this is PQA. As has just been proved, repeatedly rebasing this is tricky as it's quite a sprawling piece and every time introduces the potential for error. So I, for one, would be keen to get it in as it is, then address any enhancements to wording, particularly as they're likely to be subjective. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112231|0 |1 is obsolete| | --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112411&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112233|0 |1 is obsolete| | --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112413&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112235|0 |1 is obsolete| | --- Comment #99 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112415&action=edit Bug 24083: (follow-up) Respond to QA feedback This patch implements changes requested by Katrin in QA feedback (comment #38): - Fix QA script failures - Remove notice text database update - Fix alter table column order mismatch - Use new convention for JS strings - Fix terminology Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112237|0 |1 is obsolete| | --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112417&action=edit Bug 24083: (follow-up) Fix error in checkouts JS This commit fixes a small error in the checkouts related JS Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112239|0 |1 is obsolete| | --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112419&action=edit Bug 24083: (follow-up) Fix unit tests Some changes in issue.t had broken the tests for unseen renewals (the unseen tests were using variables that had been moved out of the tests' scope). Also now using Koha::CirculationRules::set_rules to set circ rules rather than using SQL queries. Fixed expected number of return values from GetRenewCount Moved unseen tests in issue.t to the bottom of the file to remove the risk of interference with other test circ rules. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #105 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112421&action=edit Bug 24083: (follow-up) Fix bad rebase This commit fixes a couple of lines that got missed during the last rebase Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112243|0 |1 is obsolete| | --- Comment #107 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112423&action=edit Bug 24083: (follow-up) Fix QA issues This commit fixes items 1 & 2 descibed by Katrin in comment #74 -> comment #76. - Fixed missing check for too_unseen in opac-user.tt, this test did used to exist but got lost during sizeable rebase a few weeks ago :-( - Added test for too_unseen to all AUTO_RENEWAL notice templates apart from de-DE (as previously requested by Katrin) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112410|0 |1 is obsolete| | --- Comment #109 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113073&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112412|0 |1 is obsolete| | --- Comment #111 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113075&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112414|0 |1 is obsolete| | --- Comment #113 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113077&action=edit Bug 24083: (follow-up) Fix params to AddRenewal The merging of Bug 23051 has added a paramter that can be passed to C4::AddRenewal. This bug does also, so the offset of this bug's new paramter was wrong. This patch fixes it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112416|0 |1 is obsolete| | --- Comment #115 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113079&action=edit Bug 24083: (follow-up) Include SelfCheckInModule As highlighted by Katrin, the selfcheckin module was not aware of this work. This commits gives it awareness of the too_unseen renew error and the "seen" argument that can be passed to AddRenewal Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112417|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112420|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #118 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113314&action=edit Bug 24083: Delete the new rule when needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #120 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Andrew, I think I've found some problem with this enhancement. 1. I have set the default circ rule: unseen_renewals_allowed | 2 renewalsallowed | 5 And an issue has: renewals: 2 unseen_renewals: 2 so number of unseen is reached. I am expecting a staff member to be allowed to renew, however I get: Cannot renew: E Street shuffle : ( BC_1 ) has been renewed the maximum number of consecutive times without being seen by the library ) Can you confirm it's a bug? 2. If 1. is valid, why cannot we renew from circulation.pl if the max number of renewals is not reached (but number of unseen renewals is)? 3. If I am understanding correctly, the AddRenewal call in sco-main.pl always has $seen set to 1. Maybe we should then make it hardcoded in the controller (ie. no need to have the template var) 4. It seems that the too_unseen error should be handled in misc/cronjobs/automatic_renewals.pl Don't you think? It can still be part of 20.11 if I get answers/follow-ups before Wednesday. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113073|0 |1 is obsolete| | --- Comment #121 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113484&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - Add unseen_renewals_allowed to circulation_rules - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113075|0 |1 is obsolete| | --- Comment #123 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113486&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. Signed-off-by: Sally Healey <sally.Healey@cheshirewestandchester.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113077|0 |1 is obsolete| | --- Comment #125 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113488&action=edit Bug 24083: (follow-up) Fix params to AddRenewal The merging of Bug 23051 has added a paramter that can be passed to C4::AddRenewal. This bug does also, so the offset of this bug's new paramter was wrong. This patch fixes it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113079|0 |1 is obsolete| | --- Comment #127 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113490&action=edit Bug 24083: (follow-up) Include SelfCheckInModule As highlighted by Katrin, the selfcheckin module was not aware of this work. This commits gives it awareness of the too_unseen renew error and the "seen" argument that can be passed to AddRenewal Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113314|0 |1 is obsolete| | --- Comment #129 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113492&action=edit Bug 24083: Delete the new rule when needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #131 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113494&action=edit Bug 24083: (follow-up) Make requested changes This commit makes the changes requested in comment #120 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Isherwood from comment #132)

(In reply to Jonathan Druart from comment #120)

Hi Jonathan

...

Cannot renew:

E Street shuffle : ( BC_1 ) has been renewed the maximum number of consecutive times without being seen by the library )

Can you confirm it's a bug?

I think you've missed the step in the test plan that says "Select the "Override renewal restrictions" checkbox" with this enabled, you will have the ability to override the restriction via a "Override limit and renew button"

Right, I missed that!

...

4. It seems that the too_unseen error should be handled in misc/cronjobs/automatic_renewals.pl Don't you think?

Good point, now added

But then, if we decide to send the notice, the AUTO_RENEWALS template will need to be adjust. Otherwise the notice will be generated without a correct content. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #135 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #137 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 3. We have 2 failing tests $ prove t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/checkouts.t .. 7/93 # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/checkouts.t line 198. # Structures begin differing at: # $got->{unseen_renewals} = '0' # $expected->{unseen_renewals} = Does not exist t/db_dependent/api/v1/checkouts.t .. 84/93 # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/checkouts.t line 217. # Structures begin differing at: # $got->{unseen_renewals} = '0' # $expected->{unseen_renewals} = Does not exist # Looks like you failed 2 tests of 93. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #139 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113546&action=edit Bug 24083: (QA follow-up) Fix failing tests This commit fixes the failing tests mentioned by Jonathan in comment -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #141 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113556&action=edit Bug 24083: (QA follow-up) Fix DB upgrade This commit makes the addition of the 'unseen_renewals_allowed' circulation rule idempotent, as highlighted by Jonathan in comment #140 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #143 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- As an aside, while looking through updatedatabase.pl for how this is usually handled in DB upgrades, I noticed the upgrade in Bug 14866 has the same problemhttps://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112225&action=diff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows a release notes| |library to uniquely track | |renewals where the item has | |been present distinctly | |from those where the item | |may not have been present. | | | |Additionally, this allows | |the library can set their | |circulation rules to | |require regular 'seen' | |renewals and thus prevent | |patrons from continually | |renewing a item which may | |actually have been lost. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows a |This new feature allows a release notes|library to uniquely track |library to uniquely track |renewals where the item has |renewals where the item has |been present distinctly |been present distinctly |from those where the item |from those where the item |may not have been present. |may not have been present. | | |Additionally, this allows |Additionally, this allows |the library to set their |the library to set their |circulation rules to |circulation rules to |require regular 'seen' |require regular 'seen' |renewals and thus prevent |renewals and thus prevent |patrons from continually |patrons from continually |renewing a item which may |renewing an item which may |actually have been lost. |actually have been lost. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #147 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113814&action=edit Bug 24083: (follow-up) Assign renewals remaining string to content -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #148 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #147)

Created attachment 113814 [details] [review] Bug 24083: (follow-up) Assign renewals remaining string to content

Pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #149 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29022 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29022 [Bug 29022] Allow choice of whether or not to reset Unseen renewal count on Seen renewal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29024 [Bug 29024] Renewals performed via web-based self-check should be Unseen -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 [Bug 29050] Add punctuation in Unseen Renewals message -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual-updated -- You are receiving this mail because: You are watching all bug changes.