https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51050&action=edit Bug 16403: Fix holds.t (tests 9 and 39) Resolves this: Failed test 'GetReservesFromItemnumber should return a valid borrowernumber' at t/db_dependent/Holds.t line 97. got: '2000001890' expected: '2000001889' Failed test 'Test AlterPriority(), move to bottom' at t/db_dependent/Holds.t line 220. got: '4' expected: '5' Test plan: Run the test before and after applying this patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51050|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51054&action=edit Bug 16403: Fix holds.t (tests 9 and 39) Resolves this: Failed test 'GetReservesFromItemnumber should return a valid borrowernumber' at t/db_dependent/Holds.t line 97. got: '2000001890' expected: '2000001889' Failed test 'Test AlterPriority(), move to bottom' at t/db_dependent/Holds.t line 220. got: '4' expected: '5' Test plan: Run the test before and after applying this patch. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marc Véron from comment #2)

Signed-off-by: Marc Véron <veron@veron.ch>

Thx Marc for this fast signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51054|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51073&action=edit Bug 16403: Fix holds.t (tests 9 and 39) Resolves this: Failed test 'GetReservesFromItemnumber should return a valid borrowernumber' at t/db_dependent/Holds.t line 97. got: '2000001890' expected: '2000001889' Failed test 'Test AlterPriority(), move to bottom' at t/db_dependent/Holds.t line 220. got: '4' expected: '5' Test plan: Run the test before and after applying this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5)

Created attachment 51074 [details] [review] Bug 16403: Remove unnecessary undef param

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

I explicitly added the undef to *show* that the date is not defined -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16403 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.