[Bug 16343] New: 7XX XSLT subfields displaying out of order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Bug ID: 16343 Summary: 7XX XSLT subfields displaying out of order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: danielle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 15100 Created attachment 50667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50667&action=edit Screenshot of out of order 7XX fields in display Hello, the subfields are out of order. Marc is: 700 1# - ADDED ENTRY--PERSONAL NAME a Personal name Caspary, Vera, d Dates associated with a name 1899-1987. t Title of a work Laura. Displays as such: 700, a,t,d from catalog Normal View: Caspary, Vera, Laura 1899-1987. Can the subfields be ordered alphabetically?
From Patricia
Comment 56 asked for an example. We have a title Women crime writers where several of the 700 fields have inverted the author's date subfield with the title field. See http://catalog.roundrocktexas.gov/cgi-bin/koha/opac-detail.pl?biblionumber=1.... Specifically: ex.1) Caspary, Vera, Laura 1899-1987. should be: Caspary, Vera, 1899-1987. Laura. -- ex.2) Hughes, Dorothy B. In a lonely place 1904-1993. should be: Hughes, Dorothy B.,1904-1993. In a lonely place. -- ex. 3) Holding, Elisabeth Sanxay, The blank wall 1889-1955. should be: Holding, Elisabeth Sanxay, 1889-1955. The blank wall. There are 3 more examples in this record alone. Another example is Dancing home. See: http://catalog.roundrocktexas.gov/cgi-bin/koha/opac-search.pl?idx=ti&q=dancing+home. Darío, Rubén, A Margarita 1867-1916. should be Darío, Rubén, 1867-1916. A Margarita. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 50950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50950&action=edit Marc record with multiple 7XX heading to test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 50952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50952&action=edit Bug 16343: 7XX XSLT subfields displaying out of order Patch apply for OPAC: This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the record attached - Reindex zebra - Leave empty the OPACUserCSS syspref - Go to the new record in OPAC detail page - Look the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS the css stated before - Play deleting or adding the clasess -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> ---
Playing with the three classes: By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.). Contributor(s): Weinman, Sarah | Caspary, Vera | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle)
"ith: .titleportion and .relatorcode By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.). Contributor(s): Weinman, Sarah | Caspary, Vera, 1899-1987 | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle), 1904-1993
Only title portion International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.) [depicted.]. Contributor(s): Weinman, Sarah [editor of compilation.] | Caspary, Vera, 1899-1987 | Eustis, Helen | Hughes, Dorothy B. (Dorothy Belle), 1904-1993
Without classes By: International Congress of Gerontology. Satellite Conference (1978 : Sydney, N.S.W.) [depicted.]. Contributor(s): Weinman, Sarah. [editor of compilation.] | Caspary, Vera, 1899-1987. Laura | Eustis, Helen. The horizontal man | Hughes, Dorothy B. (Dorothy Belle), 1904-1993. In a lonely place
Notice that you can play with another sort of combination -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50952|0 |1 is obsolete| | --- Comment #4 from Danielle Elder <danielle@bywatersolutions.com> --- Created attachment 51045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51045&action=edit Bug 16343: 7XX XSLT subfields displaying out of order Patch apply for OPAC: This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the record attached - Reindex zebra - Leave empty the OPACUserCSS syspref - Go to the new record in OPAC detail page - Look the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS the css stated before - Play deleting or adding the clasess Signed-off-by: Dani Elder <danielle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #5 from Danielle Elder <danielle@bywatersolutions.com> --- Thanks for the quick response, Héctor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51118&action=edit Two MARC21 records to test with multiples 7XX fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51045|0 |1 is obsolete| | --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51119&action=edit Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached wit titles: - Surface & coatings technology. - Women crime writers - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - Look the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Danielle Elder from comment #5)
Thanks for the quick response, Héctor.
Hi Danielle I attach a new patch with more changes, I've included new things to the patch, fix some mistake and also added the changes to Intranet and OPAC results. There is a new marc file with two records, staged for test purposes. Tanks for you test and sign-off Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Héctor Eduardo Castro Avalos from comment #8)
Tanks for you test and sign-off
Please re-test and re-sing-off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #10 from Danielle Elder <danielle@bywatersolutions.com> --- Ok. I am going to retest and check Intranet this time. I only checked OPAC first test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51119|0 |1 is obsolete| | --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51190&action=edit Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #12 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Danielle I rebase the patch with some typos fixed Sorry for the inconvenience -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51190|0 |1 is obsolete| | --- Comment #13 from Danielle Elder <danielle@bywatersolutions.com> --- Created attachment 51225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51225&action=edit Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51225|0 |1 is obsolete| | --- Comment #14 from Danielle Elder <danielle@bywatersolutions.com> --- Created attachment 51226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51226&action=edit Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments Signed-off-by: Dani Elder <danielle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #15 from Danielle Elder <danielle@bywatersolutions.com> --- I tested the css classes and ordering in Intranet and OPAC. Looked great. I signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Danielle, you forgot to change the bug status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #17 from Danielle Elder <danielle@bywatersolutions.com> --- Status is signed off. Do you mean in giz bz? (I am a novice here, so let me know). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hector, thx a lot for taking the time to work on this! Reading the XSLT is quite hard, but in my tests it looked alright. I am not sure this was the way of fix Winona had thought of - I'd love to get her opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is it intentional to not display 100$t any longer with this patch? Can you please check? It displays without this patch, 700$t displays with and without, but sequence is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imingchan@yahoo.com.au --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 16475 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 --- Comment #21 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Katrin Fischer from comment #19)
Is it intentional to not display 100$t any longer with this patch? Can you please check? It displays without this patch, 700$t displays with and without, but sequence is fixed.
Hi Katrin. I intencional did it since subfield $t is only used in 7XX fields in MARC bibliographic. This subfield is only used in MARC authority. If a librarian use some authorized access point with $t (name-title) subfield in bib record, the uniform title is placed in 240$a field. But if some library use 1XX$t I can include it. Regards PS: This is a policy that Library of Congress don't want to change neither LCRI nor LC-PCC PS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51226|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51613&action=edit [PASSED QA] Bug 16343: 7XX XSLT subfields displaying out of order This patch respect previous css classes .authordates and .relatorcode but also include .titleportion .authordates {display: none;} .titleportion {display: none;} .relatorcode {display: none;} To test: - Stage the two record attached with titles: - Surface & coatings technology. - Women crime writers. - Reindex zebra (necessary to Opac and Itranet results) - Leave empty the OPACUserCSS and IntranetUserCSS sysprefs - Go to the new records in OPAC and Intranet detail page - See the wrong display of dates - Apply patch and refresh the page - Test in OPACUserCSS and IntranetUserCSS the css stated before - Play deleting or adding the classes - Test with multiple records with 700 (with and without dates, etc; 710 and 711) NOTE: dates in 710 and 711 can be hidden with .titleportion class; dates in this kind of heading go with another data for example: Catholic Church. Plenary Council of Baltimore (2nd : 1866) Patch rebased some typos fixed in comments Signed-off-by: Dani Elder <danielle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05, thanks Hector! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16343 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org