http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11923 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 26111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26111&action=edit Bug 11923 - Marc record batches not sorting by citation descending When the ability to stage authority records was added to Koha, sorting record batches by citation ( i.e. title ) caused the addition of "authorized_heading" to be added to the sort. When sorting by title descending, this causes the order by clause to be "title, authorized_heading DESC" which means sort by title ASC, then authorized_heading DESC. This is incorrect and causes regular biblio batches to always be sorted ascending. Test plan: 1) Stage a batch of biblio records from a file 2) View the staged batch 3) Attempt to sort by title descending 4) Note it is still sorted by title ascending 5) Apply this patch 6) Note the sorting now works correctly -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11923 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11923 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26111|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26126&action=edit [SIGNED-OFF] Bug 11923 - Marc record batches not sorting by citation descending When the ability to stage authority records was added to Koha, sorting record batches by citation ( i.e. title ) caused the addition of "authorized_heading" to be added to the sort. When sorting by title descending, this causes the order by clause to be "title, authorized_heading DESC" which means sort by title ASC, then authorized_heading DESC. This is incorrect and causes regular biblio batches to always be sorted ascending. Test plan: 1) Stage a batch of biblio records from a file 2) View the staged batch 3) Attempt to sort by title descending 4) Note it is still sorted by title ascending 5) Apply this patch 6) Note the sorting now works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11923 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26126|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26265&action=edit Bug 11923 - Marc record batches not sorting by citation descending When the ability to stage authority records was added to Koha, sorting record batches by citation ( i.e. title ) caused the addition of "authorized_heading" to be added to the sort. When sorting by title descending, this causes the order by clause to be "title, authorized_heading DESC" which means sort by title ASC, then authorized_heading DESC. This is incorrect and causes regular biblio batches to always be sorted ascending. Test plan: 1) Stage a batch of biblio records from a file 2) View the staged batch 3) Attempt to sort by title descending 4) Note it is still sorted by title ascending 5) Apply this patch 6) Note the sorting now works correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Works as advertised. The code pertaining to sorting in routine GetImportRecordsRange will probably not win beauty prizes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11923 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11923 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Depends on Bug 10558, so I set has resolved -- You are receiving this mail because: You are watching all bug changes.