[Bug 40261] New: tidy.pl cannot handle `build-git-snapshot`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Bug ID: 40261 Summary: tidy.pl cannot handle `build-git-snapshot` Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org It needs to be considered a Perl script. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38664 CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Blocks| |40039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40039 [Bug 40039] Add production enhancements to build-git-snapshot tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40039 Blocks|40039 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40039 [Bug 40039] Add production enhancements to build-git-snapshot tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 183608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183608&action=edit Bug 40261: Teach tidy.pl how to handle build-git-snapshot This patch makes the `tidy.pl` script handle the mentioned script as a Perl script. To test: 1. Run: $ ktd --shell k$ perl misc/devel/tidy.pl debian/build-git-snapshot => FAIL: You get: ``` Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234. ``` 2. Apply this patch 3. Repeat 1 => SUCCESS: It tidies the file! 4. Reset to the current head k$ git reset --hard HEAD 5. Apply the tidy patch 6. Repeat 1 7. Run: k$ git diff => SUCCESS: No diff, the file is tidy 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183608|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 183610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183610&action=edit Bug 40261: Teach tidy.pl how to handle build-git-snapshot This patch makes the `tidy.pl` script handle the mentioned script as a Perl script. To test: 1. Run: $ ktd --shell k$ perl misc/devel/tidy.pl debian/build-git-snapshot => FAIL: You get: ``` Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234. ``` 2. Apply this patch 3. Repeat 1 => SUCCESS: It tidies the file! 4. Reset to the current head k$ git reset --hard HEAD 5. Apply the tidy patch 6. Repeat 1 7. Run: k$ git diff => SUCCESS: No diff, the file is tidy 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 183611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183611&action=edit Bug 40261: Tidy debian/build-git-snapshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183611|0 |1 is obsolete| | --- Comment #4 from David Flater <flaterdavid@gmail.com> --- Created attachment 183612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183612&action=edit Bug 40261: Tidy debian/build-git-snapshot Signed-off-by: David Flater <flaterdavid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |flaterdavid@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183610|0 |1 is obsolete| | --- Comment #5 from David Flater <flaterdavid@gmail.com> --- Created attachment 183613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183613&action=edit Bug 40261: Teach tidy.pl how to handle build-git-snapshot This patch makes the `tidy.pl` script handle the mentioned script as a Perl script. To test: 1. Run: $ ktd --shell k$ perl misc/devel/tidy.pl debian/build-git-snapshot => FAIL: You get: ``` Cannot guess filetype for debian/build-git-snapshot at misc/devel/tidy.pl line 234. ``` 2. Apply this patch 3. Repeat 1 => SUCCESS: It tidies the file! 4. Reset to the current head k$ git reset --hard HEAD 5. Apply the tidy patch 6. Repeat 1 7. Run: k$ git diff => SUCCESS: No diff, the file is tidy 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183612|0 |1 is obsolete| | --- Comment #6 from David Flater <flaterdavid@gmail.com> --- Created attachment 183614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183614&action=edit Bug 40261: Tidy debian/build-git-snapshot Signed-off-by: David Flater <flaterdavid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Will conflict with bug 39876... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39876 [Bug 39876] Centralize listing of files from our codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39876 | Blocks| |39876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39876 [Bug 39876] Centralize listing of files from our codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #7)
Will conflict with bug 39876...
Moved my change to that bug. And PQA it :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|tidy.pl cannot handle |Tidy `build-git-snapshot` |`build-git-snapshot` | --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I moved the logic change into 39876. Keeping the tidy here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183614|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183768&action=edit Bug 40261: Tidy debian/build-git-snapshot Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Simply tidy.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in| | --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Bug 40261 depends on bug 38664, which changed state. Bug 38664 Summary: Tidy the whole codebase https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40261 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to add or edit in the Koha manual regarding this change. Please reopen and provide more information if that is not the case. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org