[Bug 41271] New: pod_coverage.t skips over files that fail silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Bug ID: 41271 Summary: pod_coverage.t skips over files that fail silently Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189713&action=edit Bug 41271: Make pod_coverage.t die verbosely instead of silently To test, ktd: 1) Rollback to commit before bug 37893: git reset --hard 3f59557d2ac 2) Apply this patch 3) Reset: reset_all 4) Run the pod_coverage.t test: prove -v /kohadevbox/koha/xt/author/pod_coverage.t You get error: "Module died while loading 'C4::SIP::SIPServer': Could not find pod_coverage.xml in /kohadevbox/koha/xt/author. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |lucas@bywatersolutions.com, | |martin.renvoize@openfifth.c | |o.uk, | |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi all, I don't know what the fix should be here, but SIPServer.pm is seemingly being checked for pod_coverage.t, except it isn't. It's dying and pod_coverage.t skips over it. Questions: A) Should we push this patch (or similar)? To ensure that pod_coverage.t actually does its thing or dies verbosely. B) Do we exclude SIPServer.pm from pod_coverage altogether? C) You can skip step 1) of the test plan in the patch (that was just to highlight that issue precedes bug 37893), and you'll still reproduce the issue, for SIPServer.pm (with latest bug 37893 follow-up applied but for the reason that it dies intentionally now) and for misc/translator/TmplTokenizer.pm: Can't locate VerboseWarnings.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|pod_coverage.t skips over |pod_coverage.t |files that fail silently |unintentionally attempts to | |launch a SIP server when | |checking SIPServer.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189713|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189797&action=edit Bug 41271: Dont run Net::Server::PreFork->run on 'require' or 'use' By using 'unless caller' we ensure the class is not executed when Pod::Coverage->new does 'require C4/SIP/SIPServer.pm Ensure no regressions are added: prove t/db_dependent/SIP/* koha-sip --restart kohadev koha-sip --status kohadev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189798&action=edit Bug 41271: Fix pod_coverage for SIPServer.pm Because the file is now being properly checked for pod_coverage, it fails (because a lot of methods dont have pod coverage. Add here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189799&action=edit Bug 41271: Revert follow-up from bug 37893 This was a bad workaround. It was ugly and is no longer relevant now that pod_coverage.t no longer attempts to launch a SIP server. prove xt/author/pod_coverage.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Had a chat with Joubu about this and I agree with his opinion that the 'die' patch from bug 37893 was ugly. I believe we both agree that adding 'unless caller' to SIPServer.pm is the most sensible approach here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37893 --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- I don't think this should be backported as it's cleaning up an inconsequential bug only made evident by bug 37893 - which is not backportable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [Bug 37893] Migrate some SIP configuration into the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189828&action=edit Bug 41271: Dont run Net::Server::PreFork->run on 'require' or 'use' By using 'unless caller' we ensure the class is not executed when Pod::Coverage->new does 'require C4/SIP/SIPServer.pm Ensure no regressions are added: prove t/db_dependent/SIP/* koha-sip --restart kohadev koha-sip --status kohadev Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189829&action=edit Bug 41271: Fix pod_coverage for SIPServer.pm Because the file is now being properly checked for pod_coverage, it fails (because a lot of methods dont have pod coverage. Add here Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189830&action=edit Bug 41271: Revert follow-up from bug 37893 This was a bad workaround. It was ugly and is no longer relevant now that pod_coverage.t no longer attempts to launch a SIP server. prove xt/author/pod_coverage.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189797|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189798|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to main |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Dependency not in 25.05 - not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org