[Bug 5144] New: Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Summary: Duplicate holds allowed if patron clicks back button after placing hold Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: wizzyrea@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Here is a short screencast: http://screencast.com/t/ZGZhMDkwMjYt This shows that if a patron places a reserve, then clicks the back button, and clicks place hold again, duplicate reserves will be created. This happens even though the patron is alerted that they cannot place an additional reserve on the same item. Here is what the staff side looks like: http://screencast.com/t/ODEzNmY3 The behavior of these duplicate reserves on the items reserve list is that both are displayed, but if you try to delete one, both will be deleted and the patron loses the reserve. See above screencast. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- This bug is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- This is still true in 3.14 and master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28657&action=edit Bug 5144 [1] - Unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28658&action=edit Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply the first patch in this series 2) Run t/db_dependent/Reserves.t 3) Note the failure of test 36 4) Apply the second patch in this series 5) Re-run Reserves.t 6) Note the success of test 36 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Note, the additional changes in Reserves.t were required due to the fact that the unit test was exploiting the fact that AddReserve wasn't checking for duplicate reserves! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7710 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28658|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28659&action=edit Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply the first patch in this series 2) Run t/db_dependent/Reserves.t 3) Note the failure of test 36 4) Apply the second patch in this series 5) Re-run Reserves.t 6) Note the success of test 36 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Kyle, I don't understand the reference to "test 36". You applied this patch to our production server. While it appear to be working in that it prevents a duplicate hold, there are a couple of unexpected behaviors. 1) When you back up to the previous screen in the OPAC, the radio button for "A specific copy" is still selected, but nothing is showing. If you click on the already selected radio button, the items appear. I don't recall if this was a pre-existing condition. 2) When you select something else and try to place the hold, it just bounces you to the screen showing the hold you have already placed. There needs to be a warning that you cannot place multiple holds on the same biblio record. There is simply no explanation, and patrons can assume the hold did work. I think the issue in point 2 needs to be addressed before this patch is signed off. Christopher -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28657|0 |1 is obsolete| | Attachment #28659|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34983&action=edit Bug 5144 [1] - Unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34984&action=edit Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34985&action=edit Bug 5144 [3] - Add message for patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34983|0 |1 is obsolete| | Attachment #34984|0 |1 is obsolete| | Attachment #34985|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34986&action=edit Bug 5144 [1] - Unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34987&action=edit Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34988&action=edit Bug 5144 [3] - Add message for patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- This fails in one particular situation: 1. Search for items while not logged in. 2. From the search results page, select multiple titles, at least one (but not all) of which you already have on hold. 3. Click the "place hold" button to place multiple holds at once. 4. Log in when prompted. This process will redirect you to opac-user.pl with the "holds were not placed" message without giving you the opportunity to place a hold on the titles which you didn't have on hold. I think we could be clearer than "One or more holds were not placed due to existing holds." "Due to existing holds" could mean "because of duplicates," or it could mean "because you have too many existing holds." Maybe: "One or more holds were not placed because you already have a hold on that title." -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34986|0 |1 is obsolete| | Attachment #34987|0 |1 is obsolete| | Attachment #34988|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35090&action=edit Bug 5144 [1] - Unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35091&action=edit Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35092&action=edit Bug 5144 [3] - Add message for patron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35093&action=edit Bug 5144 [4] [QA Followup] - Fix message error and language used -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35093|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 35451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35451&action=edit Bug 5144 [4] [QA Followup] - Fix message error and language used Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 35091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35091 Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Review of attachment 35091: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5144&attachment=35091) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +161,5 @@
+ ( $biblionumber, $borrowernumber ) + ); + if ( $count > 0 ) { + carp("AddReserve: borrower $borrowernumber already has $count holds for biblionumber $biblionumber"); + return;
This will be in conflict with bug 7710. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20)
Comment on attachment 35091 [details] [review] Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold
Review of attachment 35091 [details] [review]: -----------------------------------------------------------------
::: C4/Reserves.pm @@ +161,5 @@
+ ( $biblionumber, $borrowernumber ) + ); + if ( $count > 0 ) { + carp("AddReserve: borrower $borrowernumber already has $count holds for biblionumber $biblionumber"); + return;
This will be in conflict with bug 7710.
Then the race is on! I'll have to add a followup to whichever bug is not pushed to master first. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I fail to replicate the issue in the bootstrap OPAC. I am not able to place another hold, but there is no good feedback - the button just won't work. Investigating further. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I fail to see a message on the bootstrap OPAC with the patches as well. Test done: - Place an item level hold on a record - Get redirected to patron account - Use back button of the browser - Hit 'place hold' button again - it's not functional, nothing happens Kyle, can you please take a look? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7710 | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35090|0 |1 is obsolete| | Attachment #35091|0 |1 is obsolete| | Attachment #35092|0 |1 is obsolete| | Attachment #35451|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40823&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40823|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40824&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9809 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 9809 (contrainst param removed). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40824|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42530&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #28 from Kyle M Hall <kyle.m.hall@gmail.com> --- Patch updated! (In reply to Jonathan Druart from comment #26)
Be care, AddReserve prototype changed by bug 9809 (contrainst param removed).
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42530|0 |1 is obsolete| | --- Comment #29 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 42792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42792&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn <kuhn@monterey.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I cannot reproduce this issue, when I click on the "Place hold" button, the form is not resubmitted. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok, got it using Chromium. But it makes the QA script fail: FAIL valid "my" variable $fee masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42848&action=edit Bug 5144 [QA Followup] - Remove duplicated line of code -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, I don't understand how the changes you introduced in the tests for AddReserve highlight your changes in the subroutine. It would be better to first submit a patch to fix the issue then to clean some stuffs (indentation, replacement with Koha::Objects, etc.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43118&action=edit Bug 5144 [QA Followup] - Add unit test -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42792|0 |1 is obsolete| | Attachment #42848|0 |1 is obsolete| | Attachment #43118|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43119&action=edit Bug 5144 [QA Followup] - Add unit test -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43120&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn <kuhn@monterey.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #37 from Kyle M Hall <kyle.m.hall@gmail.com> --- The updates to the unit tests in the first patch do not actually test the new functionality. Those changes were necessary to keep the tests from failing not that the patron hold limit of one per record is enforced by AddReserve. I've attached a new follow up that adds a unit test to specifically test this. I have reworked the patches to split the unit tests into a separate patch for easier testing. (In reply to Jonathan Druart from comment #33)
Kyle, I don't understand how the changes you introduced in the tests for AddReserve highlight your changes in the subroutine.
It would be better to first submit a patch to fix the issue then to clean some stuffs (indentation, replacement with Koha::Objects, etc.)
-- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43119|0 |1 is obsolete| | Attachment #43120|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43121&action=edit Bug 5144 - Add unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43122&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn <kuhn@monterey.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14695 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43121|0 |1 is obsolete| | Attachment #43122|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43125&action=edit Bug 5144 - Add unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43126&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn <kuhn@monterey.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7710 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, now that bug 5371 has been pushed, I cannot longer reproduce the issue. Should we push these changes anyway? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #43 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Jonathan Druart from comment #42)
Kyle, now that bug 5371 has been pushed, I cannot longer reproduce the issue. Should we push these changes anyway?
Yes, I believe these changes should be pushed anyway. This fixes the bug at a deeper level than bug 5371 and there is a definite possibility that future changes could cause a new regression. This fix should stop all future regressions of this behavior and has a unit test to prove it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43125|0 |1 is obsolete| | Attachment #43126|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43164&action=edit Bug 5144 - Add unit test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43165&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn <kuhn@monterey.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43166&action=edit Bug 5144: Add test on carp message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43167&action=edit Bug 5144: Don't display the failed_holds param in the url if not needed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle and Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14695 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org