[Bug 13630] New: Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Bug ID: 13630 Summary: Angular-based circulation client Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This patch is an in-progress reimplementation of the checkin/checkout interfaces using AngularJS. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13563, 12272 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Git repo? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a pretty massive piece of work me thinks... shall we get some team work going Jesse... are you following any style guidelines for your angular use? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- https://github.com/pianohacker/koha/tree/angular-circ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- 1/ 51 files changed, 5515 insertions(+), 1722 deletions(-) (11703 in it) => Should be split 2/ based on 3.16, need a rebase 3/ Squash please, ~40 commits 4/ Decent commit messages, with test plan 5/ Without test plan I had to git grep the code to know where circ/checkout.pl was called 6/ on circ/circulation.pl, More > Switch checkout client Enter a barcode, click on the Check out button, nothing append: 500 Internal Server Error in koha logs: patrons: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/koha/src/C4/Circulation.pm line 747. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Brendan gave me the angular-circ url yesterday, but https://github.com/pianohacker/koha/tree/angular-submit seems to be more recent. Jesse, could you confirm where is the work related to this bug report ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11759 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #7 from Jesse Weaver <jweaver@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)
Brendan gave me the angular-circ url yesterday, but https://github.com/pianohacker/koha/tree/angular-submit seems to be more recent.
Jesse, could you confirm where is the work related to this bug report ?
Ah, yes, sorry. The angular-submit branch is more recent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Please provide a detailed test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- This bug depends on bug 12272 and bug 13563, does the enh can be tested checking out the branch on github? Testing with the angular-submit branch: The checkout table looks broken and there are no action buttons (circ/checkout.pl), that means this patch adds a 3rd place where this table is defined. Maybe it could be good to refactor some code here. Still got the error 500. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #10 from Jesse Weaver <jweaver@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)
This bug depends on bug 12272 and bug 13563, does the enh can be tested checking out the branch on github?
Testing with the angular-submit branch: The checkout table looks broken and there are no action buttons (circ/checkout.pl), that means this patch adds a 3rd place where this table is defined. Maybe it could be good to refactor some code here.
Still got the error 500.
Will get you a detailed test plan. We were working on fixing some issues with the checkouts datatable, but any permanent fix will likely depend on Kyle. Yes, the branch should be testable simply by checking out the Github branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #11 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 36262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36262&action=edit Bug 13630 - Basic Angular circulation client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- Changed to 'needs signoff' since Jesse just attached a patch. Feel free to change back if that was inaccurate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #13 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Got this problem both in local git and sandbox: fatal: sha1 information is lacking or useless (Koha/Service.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13630 - Basic Angular circulation client It might be an easy problem so I won't change the status of the bug, but it's also a problem that means I can't test it. Any updates welcome since I'm curious about testing this to see if it gives a performance boost :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jweaver@bywatersolutions.co |ity.org |m CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch CC| |z.tajoli@cineca.it --- Comment #14 from Zeno Tajoli <z.tajoli@cineca.it> --- Patch complexity is 'Large' because this change has many architectural connections -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- fatal: sha1 information is lacking or useless (Koha/Service.pm). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org