https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36049 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36049 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36049 | --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- So the fix is different from bug 36049 which is why it's better to do it separately. But it still depend on bug 36049 to have Koha::Number::Price->round() work as expected. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 [Bug 36049] Rounding prices sometimes leads to incorrect results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

"Total tax exc. (USD)" is using Koha::Number::Price->round() and "Budgeted cost tax exc." isn't.

Likely it shouldn't. And instead should just use "Total tax exc. (USD)" and sum it with "GST" instead of the internal value. Having "Budgeted cost tax exc." also do it's own rounding(if syspref is on) from the internal value might have both be inconsistent: if one has the right value to be rounded and the other has not. Then "Total tax exc. (USD)" + "GST" sum will be different from "Budgeted cost tax exc.". As of now. It's clear from the example it's using the internal value without rounding. In the end it might need rounding after doing "Total tax exc. (USD)" + "GST". We need to be sure how it's supposed to work. ------ Likely "GST" also has this issue of not following OrderPriceRounding. So a separate value to test would be useful. Maybe vendor price = 18.90 also works? 18.90*0.95*0.1965 = 3.5281575 But then with OrderPriceRounding off it should round 3.52 with OrderPriceRounding off or should it not? Because it's always rounding to 3.53 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 --- Comment #4 from Raphael Straub <raphael.straub@kit.edu> --- The problem here is in the updateCosts() function in acq.js. The financial calculations there should be done with a decimal datatype like Big of big.js (https://github.com/MikeMcl/big.js). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 Bug 37937 depends on bug 36049, which changed state. Bug 36049 Summary: Rounding prices sometimes leads to incorrect results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.