[Bug 32335] New: Allow stock rotation items to be moved several stages ahead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Bug ID: 32335 Summary: Allow stock rotation items to be moved several stages ahead Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently when an item is added to stock rotation it can only be moved ahaead one stage, then the transfer must be filled to allow moving to the next stage. Some libraries will want to add an item to a rotation, and move it ahead to 'catch-up' with other items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144204&action=edit Bug 32335: Allow stock rotation items to be advanced when in transit This patch simply removes the disabling of the 'Move to next stage' button and adds a title to let the librarian know the item is in transit To test: 1 - Setup a rota with multiple stages 2 - Add an item 3 - Advance to next stage 4 - Observe 'Move to next stage' button is disabled 5 - Check item in at destination 6 - Reload rota - observe 'Move to next stage' is enabled 7 - Apply patch 8 - Click 'Move to next stage' 9 - Note button is not disabled 10 - Hover and confirm note about transit 11 - Click 'Move to next stage' 12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144204|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144206&action=edit Bug 32335: Allow stock rotation items to be advanced when in transit This patch simply removes the disabling of the 'Move to next stage' button and adds a title to let the librarian know the item is in transit To test: 1 - Setup a rota with multiple stages 2 - Add an item 3 - Advance to next stage 4 - Observe 'Move to next stage' button is disabled 5 - Check item in at destination 6 - Reload rota - observe 'Move to next stage' is enabled 7 - Apply patch 8 - Click 'Move to next stage' 9 - Note button is not disabled 10 - Hover and confirm note about transit 11 - Click 'Move to next stage' 12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice, discussed with Nick, and I am happy this change doesn't affect the logic in any detrimental way :) Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sounds more like an enh than a bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [% IF !in_transit && stages.size > 1 %] <a class="btn btn-default btn-xs" href="?op=move_to_next_stage&rota_id=[% rota.id | uri %]&item_id=[% sritem.id | uri %]&stage_id=[% sritem.stage.stage_id | uri %]"> [% ELSE %] - <a class="btn btn-default btn-xs" disabled> + <a class="btn btn-default btn-xs" href="?op=move_to_next_stage&rota_id=[% rota.id | uri %]&item_id=[% sritem.id | uri %]&stage_id=[% sritem.stage.stage_id | uri %]" title="Item is in transit, it will be directed to new stage when checked in"> [% END %] Just looking at this code. I am wondering how you could say that the item is in transit? Since we also have the stages.size condition ! Needs feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Marcel, I'm not sure I understand your question here.. could you clarify what you mean? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #6)
Sorry Marcel, I'm not sure I understand your question here.. could you clarify what you mean?
Compare if-condition with comment in else branch. If A and B does not mean that A is false in the else. B could be false? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144206|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148747&action=edit Bug 32335: Allow stock rotation items to be advanced when in transit This patch simply removes the disabling of the 'Move to next stage' button and adds a title to let the librarian know the item is in transit To test: 1 - Setup a rota with multiple stages 2 - Add an item 3 - Advance to next stage 4 - Observe 'Move to next stage' button is disabled 5 - Check item in at destination 6 - Reload rota - observe 'Move to next stage' is enabled 7 - Apply patch 8 - Click 'Move to next stage' 9 - Note button is not disabled 10 - Hover and confirm note about transit 11 - Click 'Move to next stage' 12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148747|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148748&action=edit Bug 32335: Allow stock rotation items to be advanced when in transit This patch adjusts the logic so that we check: 1 - If there are less than 2 stages we disable the 'Move to next stage' button 2 - If the item is not in transit, we show move to next normally 3 - If the item is in transit (and there is more than 1 stage) the button is enabled with a note about transfer To test: 1 - Setup a rota with multiple stages 2 - Add an item 3 - Advance to next stage 4 - Observe 'Move to next stage' button is disabled 5 - Check item in at destination 6 - Reload rota - observe 'Move to next stage' is enabled 7 - Apply patch 8 - Click 'Move to next stage' 9 - Note button is not disabled 10 - Hover and confirm note about transit 11 - Click 'Move to next stage' 12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148748|0 |1 is obsolete| | --- Comment #10 from Sam Lau <samalau@gmail.com> --- Created attachment 151491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151491&action=edit Bug 32335: Allow stock rotation items to be advanced when in transit This patch adjusts the logic so that we check: 1 - If there are less than 2 stages we disable the 'Move to next stage' button 2 - If the item is not in transit, we show move to next normally 3 - If the item is in transit (and there is more than 1 stage) the button is enabled with a note about transfer To test: 1 - Setup a rota with multiple stages 2 - Add an item 3 - Advance to next stage 4 - Observe 'Move to next stage' button is disabled 5 - Check item in at destination 6 - Reload rota - observe 'Move to next stage' is enabled 7 - Apply patch 8 - Click 'Move to next stage' 9 - Note button is not disabled 10 - Hover and confirm note about transit 11 - Click 'Move to next stage' 12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151491|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155322&action=edit Bug 32335: Allow stock rotation items to be advanced when in transit This patch adjusts the logic so that we check: 1 - If there are less than 2 stages we disable the 'Move to next stage' button 2 - If the item is not in transit, we show move to next normally 3 - If the item is in transit (and there is more than 1 stage) the button is enabled with a note about transfer To test: 1 - Setup a rota with multiple stages 2 - Add an item 3 - Advance to next stage 4 - Observe 'Move to next stage' button is disabled 5 - Check item in at destination 6 - Reload rota - observe 'Move to next stage' is enabled 7 - Apply patch 8 - Click 'Move to next stage' 9 - Note button is not disabled 10 - Hover and confirm note about transit 11 - Click 'Move to next stage' 12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155323&action=edit Bug 32335: (QA follow-up) Add 'Actions' label to 'Actions' column Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155324&action=edit Bug 32335: (QA follow-up) Add 'btn-primary' instead of 'btn-default' class to dialog Save buttons Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Cataloging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32335 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org