http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checkout / patron pages: |Checkout / patron pages: |Hide menu items leading to |Hide menu items leading to |404 pages |404 page -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386 --- Comment #3 from Lucio Moraes <lmoraes@catalyst.net.nz> --- Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages Some of the menu items on patron / Checkout related pages lead to a 404 page depending on the permissions. This patch hides them as appropriate. To test: - For a staff member A, set permission 'borrowers' only (+ 'catalogue') - Log in as A - Search a patron and display details - Verify that none of the menu items at the left lead to the 404 page - For a staff member B, set permission 'circulate_remaining_permission' only (+ catalogue) - Log in as B - Go to Circulation > Checkout, search a patron - Click menu items at the left, some of them lead to the 404 page - Verify that none of the menu items at the left lead to the 404 page - Do the same for a staff member C with both permissions set - Verify that menu items appear as expecte Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45726|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45987&action=edit Bug 15386: Checkout / patron pages: Hide menu items leading to 404 pages Some of the menu items on patron / Checkout related pages lead to a 404 page depending on the permissions. This patch hides them as appropriate. To test: - For a staff member A, set permission 'borrowers' only (+ 'catalogue') - Log in as A - Search a patron and display details - Verify that none of the menu items at the left lead to the 404 page - For a staff member B, set permission 'circulate_remaining_permission' only (+ catalogue) - Log in as B - Go to Circulation > Checkout, search a patron - Click menu items at the left, some of them lead to the 404 page - Verify that none of the menu items at the left lead to the 404 page - Do the same for a staff member C with both permissions set - Verify that menu items appear as expected Signed-off-by: Lucio Moraes <lmoraes@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: I have remove the double if CAN_user_circulate_circulate_remaining_permissions statement (and group block into one). And also remove unecessary change ('IF a IF b' instead of existing 'IF a && b') -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15386 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.