[Bug 15309] New: Use Bootstrap modal for cataloging search MARC and Card preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Bug ID: 15309 Summary: Use Bootstrap modal for cataloging search MARC and Card preview Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 8290 The "MARC" and "Card" links on the cataloging search results page should trigger previews in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45419&action=edit Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 4. Perform a search which will return results from the reservoir. 5. Test the corresonding "MARC" and "Card" links for those results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45419|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 45430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45430&action=edit Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 4. Perform a search which will return results from the reservoir. 5. Test the corresonding "MARC" and "Card" links for those results. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45430|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45440&action=edit [PASSED QA] Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 4. Perform a search which will return results from the reservoir. 5. Test the corresonding "MARC" and "Card" links for those results. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Owen! On a side note, it would be nice if the cataloging modal was large like the stage records modal. Not sure what is making it smaller. Maybe this should be considered a minor bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Severity|normal |enhancement --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org