[Bug 25299] New: Date not showing on Details page when patron is going to expire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Bug ID: 25299 Summary: Date not showing on Details page when patron is going to expire Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The date doesn't show on the Details page when the patron is going to expire. It does appear on the "Check out" page, however. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22134 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 103819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103819&action=edit Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103819|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 103822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103822&action=edit Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Without this patch the display was incomplete on patron detail tab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Thanks, Frédéric. Much appreciated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103822|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103879&action=edit Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Without this patch the dispay was incomplete on patron detail tab Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #5)
Good catch!
Thanks but I can't take the credit. We upgraded one of our libraries to 19.11 recently, and a librarian there has a very keen eye! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25299 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34462 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org