[Bug 34852] New: Use template wrapper for breadcrumbs: OPAC part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Bug ID: 34852 Summary: Use template wrapper for breadcrumbs: OPAC part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 34849 To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use the new template wrapper for breadcrumbs. - ilsdi.tt - opac-ISBDdetail.tt - opac-MARCdetail.tt - opac-advsearch.tt - opac-alert-subscribe.tt - opac-auth-MARCdetail.tt - opac-auth-detail.tt - opac-authorities-home.tt - opac-authoritiessearchresultlist.- - opac-blocked.tt - opac-browse.tt - opac-browser.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 [Bug 34849] Use template wrapper for breadcrumbs: OPAC part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155960&action=edit Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Navigate to /cgi-bin/koha/ilsdi.pl - Check a variety of links in the list - Advanced search - Locate a bibliographic record and view the ISBD detail page - View the MARC detail page - Locate a serial record which has a patron notification notice defined in its subscription details - On the detail view under the "Subscriptions" tab, click the "Subscribe to email notification on new issues" button. - Confirm the subscription, then when you return to the detail page, click "Cancel email notification" to check that view as well. - Authority search - Perform a search which will return results - Click the "Details" link on one of the results - Also view the "MARC view" tab (note that I didn't address the breadcrumb inconsistency between the normal and MARC view in this patch). - Try to view a bibliographic record which is suppressed in the OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set to "An explanatory page" - Set the value of 952$n to 1 to suppress it in the OPAC. - In a system with ElasticSearch enabled, go to "Browse search" (or navigate directly to /cgi-bin/koha/opac-browse.pl - With OpacBrowser enabled, go to "Browse by hierarchy." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34855 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155960|0 |1 is obsolete| | --- Comment #2 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 157053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157053&action=edit Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Navigate to /cgi-bin/koha/ilsdi.pl - Check a variety of links in the list - Advanced search - Locate a bibliographic record and view the ISBD detail page - View the MARC detail page - Locate a serial record which has a patron notification notice defined in its subscription details - On the detail view under the "Subscriptions" tab, click the "Subscribe to email notification on new issues" button. - Confirm the subscription, then when you return to the detail page, click "Cancel email notification" to check that view as well. - Authority search - Perform a search which will return results - Click the "Details" link on one of the results - Also view the "MARC view" tab (note that I didn't address the breadcrumb inconsistency between the normal and MARC view in this patch). - Try to view a bibliographic record which is suppressed in the OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set to "An explanatory page" - Set the value of 952$n to 1 to suppress it in the OPAC. - In a system with ElasticSearch enabled, go to "Browse search" (or navigate directly to /cgi-bin/koha/opac-browse.pl - With OpacBrowser enabled, go to "Browse by hierarchy." Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #3 from Philip Orr <philip.orr@lmscloud.de> --- (In reply to Philip Orr from comment #2)
- Try to view a bibliographic record which is suppressed in the OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set to "An explanatory page" - Set the value of 952$n to 1 to suppress it in the OPAC.
That should be 942$n. :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157053|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157055&action=edit Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Navigate to /cgi-bin/koha/ilsdi.pl - Check a variety of links in the list - Advanced search - Locate a bibliographic record and view the ISBD detail page - View the MARC detail page - Locate a serial record which has a patron notification notice defined in its subscription details - On the detail view under the "Subscriptions" tab, click the "Subscribe to email notification on new issues" button. - Confirm the subscription, then when you return to the detail page, click "Cancel email notification" to check that view as well. - Authority search - Perform a search which will return results - Click the "Details" link on one of the results - Also view the "MARC view" tab (note that I didn't address the breadcrumb inconsistency between the normal and MARC view in this patch). - Try to view a bibliographic record which is suppressed in the OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set to "An explanatory page" - Set the value of 942$n to 1 to suppress it in the OPAC. - In a system with ElasticSearch enabled, go to "Browse search" (or navigate directly to /cgi-bin/koha/opac-browse.pl - With OpacBrowser enabled, go to "Browse by hierarchy." Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157055|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157155&action=edit Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - Navigate to /cgi-bin/koha/ilsdi.pl - Check a variety of links in the list - Advanced search - Locate a bibliographic record and view the ISBD detail page - View the MARC detail page - Locate a serial record which has a patron notification notice defined in its subscription details - On the detail view under the "Subscriptions" tab, click the "Subscribe to email notification on new issues" button. - Confirm the subscription, then when you return to the detail page, click "Cancel email notification" to check that view as well. - Authority search - Perform a search which will return results - Click the "Details" link on one of the results - Also view the "MARC view" tab (note that I didn't address the breadcrumb inconsistency between the normal and MARC view in this patch). - Try to view a bibliographic record which is suppressed in the OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set to "An explanatory page" - Set the value of 942$n to 1 to suppress it in the OPAC. - In a system with ElasticSearch enabled, go to "Browse search" (or navigate directly to /cgi-bin/koha/opac-browse.pl - With OpacBrowser enabled, go to "Browse by hierarchy." Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Bug 34852 depends on bug 34849, which changed state. Bug 34849 Summary: Use template wrapper for breadcrumbs: OPAC part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is more an enhancement, not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org