https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36951 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36951 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35093 Status|ASSIGNED |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35093 [Bug 35093] ILL table is broken -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36951 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Mid-air collision there with Tomas. I'm setting this as 'NEW' for now if that's okay? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36951 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 167120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167120&action=edit Bug 36951: Fix embed name mismatch batch vs. ill_batch This patch fixes a query error on the ILL requests page. This comes from an incomplete fix from bug 35093, which correctly renamed the `batch` embed to `ill_batch`, but missed to change the column `data` attribute on the DataTable. Because of that, when doing keyword searches, the KohaTable component generates a query on `batch.name` instead of `ill_batch.name`, which generates a 500 error (because Koha is not returning the right status on DB query errors). To reproduce: 1. Have your KTD up, with some ILL backend: $ ktd --shell k$ bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2. Go to the ILL requests page 3. Perform any query on the top level filter box => FAIL: You get a 500. The logs say: ``` [ERROR] GET /api/v1/ill/requests: unhandled exception (Koha::Exceptions::BadParameter)<<Exception 'Koha::Exceptions::BadParameter' thrown 'Cannot find Koha::Object class for batch'>> ``` 4. Apply this patch 5. Reload all the page contents (ctrl+shift+r or cmd+shift+r) 6. Repeat 3 => SUCCESS: No error! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.