[Bug 42163] New: wrapper-staff-tool-plugin.inc no longer loads the admin menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Bug ID: 42163 Summary: wrapper-staff-tool-plugin.inc no longer loads the admin menu Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org 41367 broke the wrapper for the plugin and it no longer loads on plugins when using the wrapper. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 [Bug 41367] Staff user interface - no sidebar menu when on record sources pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #1 from Lisette Scheer <lisette@bywatersolutions.com> --- To recreate, install the kitchen sink plugin and navigate to the admin page for it. Observe there's no menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|NEW |CONFIRMED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Lisette Scheer <lisette@bywatersolutions.com> --- This patch updates the plugin wrapper to use the main-container.inc, which allows it to call the vue islands. To Test: BEFORE APPLYING THE PATCH 1. Install the kitchen sink plugin 2. Navigate to Admin->Plugins and configure the kitchen sink plugin 3. See there is no menu on the left hand side of the page. 4. Go to tools->kitchen sink tool plugin 5. Observe there is a menu bar on the left hand size 6. Go to reports->kitchen sink plugin 7. Observe there is a menu bar on the left hand size 8. Apply the patch 9. Repeat steps 2,4, and 6 10. Observe they all have the menu that matches the area (tool=tool menu, report=report menu, admin/configure=admin menu) 11. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #3 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 196101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196101&action=edit Bug 42163: Allow plugin wrapper to load VueJS Patch from commit c241f3e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Sponsorship status|--- |Unsponsored Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196109&action=edit Bug 42163: Allow plugin wrapper to load VueJS Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for the quick fix here Lisette, fantastic work. Going for a fast QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- This sounds pretty good but if we use "jsinclude" in the wrapper, does that mean we can't use jsinclude in the plugin? Or does the plugin just override it and then it's up to the plugin to supply [% Asset.js("js/admin-menu.js") | $raw %] in its own jsinclude? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #6)
This sounds pretty good but if we use "jsinclude" in the wrapper, does that mean we can't use jsinclude in the plugin? Or does the plugin just override it and then it's up to the plugin to supply [% Asset.js("js/admin-menu.js") | $raw %] in its own jsinclude?
Looking at an old plugin I did with a plugin wrapper and I did include a jsinclude in it. I think it probably just a case then of the latter overriding the former. -- It's outside the scope of this change, but I have been thinking that we need a mechanism to replace jsinclude, so that one can provide multiple blocks. You can see at koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt that the ILL stuff works around it a bit by using backend_jsinclude but that's still a case of only being able to add 1 more... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Lisette Scheer from comment #2)
This patch updates the plugin wrapper to use the main-container.inc, which allows it to call the vue islands.
To Test: BEFORE APPLYING THE PATCH 1. Install the kitchen sink plugin 2. Navigate to Admin->Plugins and configure the kitchen sink plugin 3. See there is no menu on the left hand side of the page. 4. Go to tools->kitchen sink tool plugin 5. Observe there is a menu bar on the left hand size 6. Go to reports->kitchen sink plugin 7. Observe there is a menu bar on the left hand size 8. Apply the patch 9. Repeat steps 2,4, and 6 10. Observe they all have the menu that matches the area (tool=tool menu, report=report menu, admin/configure=admin menu) 11. Sign off!
So... I cannot get this to work... even the plugins-home.pl page won't show left nav menu so that's interesting... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
So... I cannot get this to work... even the plugins-home.pl page won't show left nav menu so that's interesting...
Ok so plugins-home.pl not loading the left hand nav is a separate (yet related) issue... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
(In reply to Lisette Scheer from comment #2)
This patch updates the plugin wrapper to use the main-container.inc, which allows it to call the vue islands.
To Test: BEFORE APPLYING THE PATCH 1. Install the kitchen sink plugin 2. Navigate to Admin->Plugins and configure the kitchen sink plugin 3. See there is no menu on the left hand side of the page. 4. Go to tools->kitchen sink tool plugin 5. Observe there is a menu bar on the left hand size 6. Go to reports->kitchen sink plugin 7. Observe there is a menu bar on the left hand size 8. Apply the patch 9. Repeat steps 2,4, and 6 10. Observe they all have the menu that matches the area (tool=tool menu, report=report menu, admin/configure=admin menu) 11. Sign off!
So... I cannot get this to work... even the plugins-home.pl page won't show left nav menu so that's interesting...
So this is where the test plan could be improved. It's not clear what "Install the kitchen sink plugin" strictly means. Typically, when I install the kitchen sink plugin, I go to https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/releases and take the latest packaged release But... it looks like the last release was from August 2025 and the plugin version has been stuck on 2.6.3 since then. So if I go to /var/lib/koha/kohadev and git clone dev-koha-plugin-kitchen-sink.git and then move the Koha up a level... Nope still doesn't really work. /cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3ACom%3A%3AByWaterSolutions%3A%3AKitchenSink&method=report This gets a few Javascript errors because it can't find datepicker.js and datepicker.css, and the aside nav doesn't load. The aside nav does load now when going to "Run admin tool" or to "Configure", but "Run tool" doesn't show the aside nav. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Lisette Scheer <lisette@bywatersolutions.com> --- My bad David, please use Kitchen Sink v.2.7.1 (or later if we do more releases) https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from David Nind <david@davidnind.com> --- This doesn't seem to work as expected after the patch (actually, I'm not sure what is expected after the patch - some pages have a sidebar menu, some don't, so doesn't match with step 10 of the test plan): 1. OK: 1.1 Administration > Plugins > Manage plugins, for the Example Kitchen-Sink Plugin select Actions > Configure: . Before: no sidebar menu . After: now has sidebar menu: System preferences ... Note: The plugins page (listing the plugins) has no sidebar menu. 2. OK: 2.1 Administration > Plugins > Example Kitchen-Sink Plugin (this is the link on the administration page under Plugins): . Before: no sidebar menu . After: Get "Administration demonstration" page with sidebar menu: System preferences... 3. OK - no change: 3.1 Tools > Additional tools > Tool plugins (click the "Tool plugin" link): . Before: on the plugins page, has sidebar starting with Tools home, Patrons and circulation... . After: on the plugins page, has sidebar starting with Tools home, Patrons and circulation... Note: after patch: . Actions > Run tool, get the "Click me" page with no sidebar menu . Actions > Run admin tool, get the "Administration demonstration page with sidebar menu 4. Change - has sidebar menu before patch, after patch has no sidebar menu: 4.1 Tools > Additional tools > Tool plugins > Example Kitchen-Sink Plugin (this is the link under "Use tool plugins"): . Before: Get "Kitchen Sink Plugin: Example Tool" page with the "Click me", has the sidebar menu starting with Tools home, Patrons and circulation... . After: Get "Kitchen Sink Plugin: Example Tool" page with the "Click me", no sidebar menu 5. No change - before and after patch does not have sidebar menu: 5.1 Reports > Report plugins, click the "Report plugins" link: . Before: get plugins page with no sidebar menu (Breadcrumb = Administration > Plugins, URL = /cgi-bin/koha/plugins/plugins-home.pl?method=report) . After: get plugins page with no sidebar menu (Breadcrumb = Administration > Plugins, URL = /cgi-bin/koha/plugins/plugins-home.pl?method=report) 6. No change - before and after patch does not have sidebar menu: 6.1 Reports > Report plugins, click the "Report plugins" link, for the Example Kitchen-Sink Plugin select Actions > Run report . Before: get "Generate List of Patrons" page with no sidebar menu . After: get "Generate List of Patrons" page with no sidebar menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
(In reply to David Cook from comment #6)
This sounds pretty good but if we use "jsinclude" in the wrapper, does that mean we can't use jsinclude in the plugin? Or does the plugin just override it and then it's up to the plugin to supply [% Asset.js("js/admin-menu.js") | $raw %] in its own jsinclude?
Looking at an old plugin I did with a plugin wrapper and I did include a jsinclude in it. I think it probably just a case then of the latter overriding the former.
--
It's outside the scope of this change, but I have been thinking that we need a mechanism to replace jsinclude, so that one can provide multiple blocks.
You can see at koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt that the ILL stuff works around it a bit by using backend_jsinclude but that's still a case of only being able to add 1 more...
So I found a template where the jsinclude actually just includes other BLOCKs that I set elsewhere. If we had a "plugin_js" BLOCK or something that could also be an option.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- I think I might have different results than David... Before the patch: -> Configure has no left nav -> Tool has contextually appropriate left nav -> Report has contextually appropriate left nav After the patch: -> Configure has a contextually appropriate left nav -> Admin tool has a contextually appropriate left nav -> Tool has no left nav -> Report has no left nav -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- Created attachment 196903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196903&action=edit Bug 42163: Allow plugin wrapper to load VueJS Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Created attachment 196904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196904&action=edit Bug 42163: (follow-up) fix plugin wrapper menus, plugins-home.tt, and plugins-upload.tt Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 196904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196904 Bug 42163: (follow-up) fix plugin wrapper menus, plugins-home.tt, and plugins-upload.tt Review of attachment 196904: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=42163&attachment=196904) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc @@ +57,2 @@
[% ELSIF (method == 'report' ) %] + [% SET 'dynamicaside' = 'reports-menu' %]
There was a little typo in the name of the aside for tools and reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- I needed to add a follow-up to get this working. Marking it as signed off since it now works for me. Added a couple other tweaks to plugins-home.tt and plugins-upload.tt related to the side nav and top nav. @David Nind: If you sign this one off, we could upgrade this to Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196903|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 196949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196949&action=edit Bug 42163: Allow plugin wrapper to load VueJS Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 196950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196950&action=edit Bug 42163: (follow-up) fix plugin wrapper menus, plugins-home.tt, and plugins-upload.tt Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the sidebar release notes| |menus when using plugins. | |The appropriate sidebar | |menu is now shown, | |depending on the type of | |plugin (such as | |administration, tools, or | |reports). Previously, no | |sidebar menu was appearing | |in some circumstances. --- Comment #21 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #18)
I needed to add a follow-up to get this working. Marking it as signed off since it now works for me. Added a couple other tweaks to plugins-home.tt and plugins-upload.tt related to the side nav and top nav.
@David Nind: If you sign this one off, we could upgrade this to Passed QA
Thanks David. Have added my sign off. Everything seems to work consistently now - thanks for the follow-up that fixed things. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|martin.renvoize@openfifth.c |dcook@prosentient.com.au |o.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42322 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #22 from Lisette Scheer <lisette@bywatersolutions.com> --- I needed to fix a merge error, patch should apply again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #23 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 197232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197232&action=edit Bug 42163: (follow-up) fix plugin wrapper menus, plugins-home.tt, and plugins-upload.tt Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42352 [Bug 42352] Add ability to do multi level breadcrumbs in wrapper-staff-tool-plugin.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #24 from Lisette Scheer <lisette@bywatersolutions.com> --- Arg, somehow some merge stuff made it in. Will upload new patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196950|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #25 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 197233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197233&action=edit Bug 42163: (follow-up) fix plugin wrapper menus, plugins-home.tt, and plugins-upload.tt Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- With this patchset applied I visit the plugin home page and get: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt line 195: unexpected token (ELSE) Also, seems to introduce some unclosed HTML tags: [error] mhx4V5ZutB.tt: SyntaxError: Unexpected closing tag "td". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-e... (4:45) [error] 2 | <strong>#~107~#</strong> [error] 3 | <span class="badge text-bg-warning">ERRORS</span> [error] > 4 | </td> [error] | ^^^^^ [error] 5 | #~111~# [error] 6 | </tr> and tidiness: FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- Ah Lisette's merge must've messed something up I'm guessing. @Lisette, could you have another crack at this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #28 from David Cook <dcook@prosentient.com.au> --- Or actually... I can do it I think -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196949|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- Created attachment 197466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197466&action=edit Bug 42163: Allow plugin wrapper to load VueJS Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #30 from David Cook <dcook@prosentient.com.au> --- Created attachment 197467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197467&action=edit Bug 42163: (follow-up) fix plugin wrapper menus, plugins-home.tt, and plugins-upload.tt Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #31 from David Cook <dcook@prosentient.com.au> --- Hmm it's working but still complaining about tidiness which is interesting as it auto-tidied... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #32 from David Cook <dcook@prosentient.com.au> --- Created attachment 197468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197468&action=edit Bug 42163: (follow-up) fix plugin wrapper menus, plugins-home.tt, and plugins-upload.tt Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- Ok that should be good now. LUcas, can you have another go? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534 [Bug 42534] wrapper-staff-tool-plugin.inc interferes with js and includes in template files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 --- Comment #35 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org