[Bug 43401] New: Makefile.PL doesn't compile vue OPAC js to the right directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Bug ID: 43401 Summary: Makefile.PL doesn't compile vue OPAC js to the right directory Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- We've notices a problem on sites now using 26.05 and problems with vue island related stuff. I found the problem through the new self renewal via OPAC feature which has a modal loaded through: koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/PatronSelfRenewal/PatronSelfRenewal.vue The compiled js files on the 26.05 server only show in the intranet directory: intranet-tmpl/prog/js/vue/dist/patron-self-renewal The code expects this in an opac directory. I think MakeFile.PL just isnt accounting for this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 204348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204348&action=edit Bug 43401: Send compiled js vue for the OPAC to the right dir Not sure about a test plan here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |matt.blenkinsop@openfifth.c | |o.uk, | |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Not so sure about this one, asking for some help :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I'm not sure that I understand what you're saying in the description, but it's a reasonable change to make in any case if we're adding Vue into the OPAC. For a test plan, take a look at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39849#c6 Basically, I do a "single" build from source and just check that it gets deployed in the right place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (I just noticed this one by chance. For architectural things like this, feel free to CC me in. I should ask to be added to the default CC for architecture...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |sbrown@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Ah damn, yes, missed that Makefile change. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204348|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204349&action=edit Bug 43401: Send compiled js vue for the OPAC to the right dir Not sure about a test plan here. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204356&action=edit Bug 43401: Send compiled js vue for the OPAC to the right dir The OPAC vue bundle (koha-tmpl/opac-tmpl/bootstrap/js/vue/dist) was not handled like its intranet counterpart in Makefile.PL: exclude it from the generic target map and copy it explicitly into blib in move_compiled_js. Test plan: 1. In a KTD shell, from the koha checkout: perl Makefile.PL (accept the defaults, 'standard' install mode is fine) 2. make -n move_compiled_js | grep 'js/vue/dist' => without this patch only the intranet cp line is printed; with it there is also a line copying koha-tmpl/opac-tmpl/bootstrap/js/vue/dist into blib/OPAC_TMPL_DIR/bootstrap/js/vue/ 3. make 4. ls blib/INTRANET_TMPL_DIR/prog/js/vue/dist blib/OPAC_TMPL_DIR/bootstrap/js/vue/dist => both directories exist and contain the compiled bundles (e.g. islands.esm.js); no vue/dist directory is left anywhere else under blib. 5. git clean -xdf blib pm_to_blib Makefile Makefile.old && git checkout -- . to clean up. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204357&action=edit Bug 43401: (follow-up) Note the Makefile.PL coupling in rspack.config.js - Add a file-level comment reminding that every shipped output.path needs a matching 'NONE' target-map entry and cp step in Makefile.PL Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I added a comment to the rspack config file and a test plan for Lucas' patch. Maybe we should even add a coding guideline to check for stuff like this whenever we emit something. Sorry, was my mistake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Paul Derscheid from comment #9)
I added a comment to the rspack config file and a test plan for Lucas' patch.
Maybe we should even add a coding guideline to check for stuff like this whenever we emit something. Sorry, was my mistake.
Thanks Paul! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Paul Derscheid from comment #7)
Test plan: 1. In a KTD shell, from the koha checkout: perl Makefile.PL (accept the defaults, 'standard' install mode is fine)
I'd prefer "single" with an install dir of /opt/koha, but sure.
2. make -n move_compiled_js | grep 'js/vue/dist' => without this patch only the intranet cp line is printed; with it there is also a line copying koha-tmpl/opac-tmpl/bootstrap/js/vue/dist into blib/OPAC_TMPL_DIR/bootstrap/js/vue/
So that's a problem because we're trying to find it in "js/vue/dist": grep -R "/vue/dist" /opt/koha/opac/htdocs/opac-tmpl/* --exclude="*.min.js*" --exclude="*.map*" /opt/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-user.tt:[% SET islands = Asset.js("js/vue/dist/islands.esm.js").match('(src="([^"]+)")').1 %]
3. make 4. ls blib/INTRANET_TMPL_DIR/prog/js/vue/dist blib/OPAC_TMPL_DIR/bootstrap/js/vue/dist => both directories exist and contain the compiled bundles (e.g. islands.esm.js); no vue/dist directory is left anywhere else under blib.
But both directories don't exist: kohadev-koha@kohadevbox:koha(bug_43401)$ ls blib/INTRANET_TMPL_DIR/prog/js/vue/dist acquisitions.js admin-menu.40c7c23d28770ef8.esm.js ill.js.map sip2.js acquisitions.js.map admin-menu.40c7c23d28770ef8.esm.js.map islands.esm.js sip2.js.map acquisitions-menu.c09a1c8d56bf1c61.js admin-menu.699a618ebbcdea9b.js islands.esm.js.map vendor-menu.ca0b96e230ffffb2.js acquisitions-menu.c09a1c8d56bf1c61.js.map admin-menu.699a618ebbcdea9b.js.map islands.js vendor-menu.ca0b96e230ffffb2.js.map acquisitions-menu.c9a796d3a4310bd7.esm.js erm.js islands.js.map vendor-menu.f9089946d9ea2fb9.esm.js acquisitions-menu.c9a796d3a4310bd7.esm.js.map erm.js.map preservation.js vendor-menu.f9089946d9ea2fb9.esm.js.map admin ill.js preservation.js.map kohadev-koha@kohadevbox:koha(bug_43401)$ ls blib/OPAC_TMPL_DIR/bootstrap/js/vue/ islands.esm.js islands.esm.js.map patron-self-renewal.d9bbd0b66f921f5d.esm.js patron-self-renewal.d9bbd0b66f921f5d.esm.js.map The "/dist" is being dropped for the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204356|0 |1 is obsolete| | Attachment #204357|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 205474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205474&action=edit Bug 43401: Send compiled js vue for the OPAC to the right dir The OPAC vue bundle (koha-tmpl/opac-tmpl/bootstrap/js/vue/dist) was not handled like its intranet counterpart in Makefile.PL: exclude it from the generic target map and copy it explicitly into blib in move_compiled_js. Test plan: 1. In a KTD shell, from the koha checkout: perl Makefile.PL (accept the defaults, 'standard' install mode is fine) 2. make -n move_compiled_js | grep 'js/vue/dist' => without this patch only the intranet cp line is printed; with it there is also a line copying koha-tmpl/opac-tmpl/bootstrap/js/vue/dist into blib/OPAC_TMPL_DIR/bootstrap/js/vue/ 3. make 4. ls blib/INTRANET_TMPL_DIR/prog/js/vue/dist blib/OPAC_TMPL_DIR/bootstrap/js/vue/dist => both directories exist and contain the compiled bundles (e.g. islands.esm.js); no vue/dist directory is left anywhere else under blib. 5. git clean -xdf blib pm_to_blib Makefile Makefile.old && git checkout -- . to clean up. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- Created attachment 205475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205475&action=edit Bug 43401: (follow-up) Note the Makefile.PL coupling in rspack.config.js - Add a file-level comment reminding that every shipped output.path needs a matching 'NONE' target-map entry and cp step in Makefile.PL Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Created attachment 205476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205476&action=edit Bug 43401: (QA follow-up) tweak rspack.config.js comment and fix Makefile.PL Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- Added a follow-up which has it working now which we can prove after a "make install": kohadev-koha@kohadevbox:koha(bug_43401)$ ls /opt/koha/intranet/htdocs/intranet-tmpl/prog/js/vue/dist acquisitions.js admin-menu.40c7c23d28770ef8.esm.js ill.js.map sip2.js acquisitions.js.map admin-menu.40c7c23d28770ef8.esm.js.map islands.esm.js sip2.js.map acquisitions-menu.c09a1c8d56bf1c61.js admin-menu.699a618ebbcdea9b.js islands.esm.js.map vendor-menu.ca0b96e230ffffb2.js acquisitions-menu.c09a1c8d56bf1c61.js.map admin-menu.699a618ebbcdea9b.js.map islands.js vendor-menu.ca0b96e230ffffb2.js.map acquisitions-menu.c9a796d3a4310bd7.esm.js erm.js islands.js.map vendor-menu.f9089946d9ea2fb9.esm.js acquisitions-menu.c9a796d3a4310bd7.esm.js.map erm.js.map preservation.js vendor-menu.f9089946d9ea2fb9.esm.js.map admin ill.js preservation.js.map kohadev-koha@kohadevbox:koha(bug_43401)$ ls /opt/koha/opac/htdocs/opac-tmpl/bootstrap/js/vue/dist islands.esm.js islands.esm.js.map patron-self-renewal.d9bbd0b66f921f5d.esm.js patron-self-renewal.d9bbd0b66f921f5d.esm.js.map Voila :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi David, thanks. The dangers of cargo culting, huh? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #17 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #18)
Nice work everyone!
Pushed to 26.05.x for the upcoming 26.05.03 release.
Correction, pushed for 26.05.04 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org